Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public network access to workspace #22542

Merged

Conversation

asensionacher
Copy link
Contributor

Adding PublicNetworkAccess to azurerm_virtual_desktop_workspace resource

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @asensionacher - LGTM 🌳

@stephybun stephybun requested a review from katbyte August 7, 2023 13:15
@stephybun
Copy link
Member

Tests look good:
image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌩️

@stephybun stephybun merged commit 8a186b0 into hashicorp:main Aug 9, 2023
23 checks passed
@github-actions github-actions bot added this to the v3.69.0 milestone Aug 9, 2023
stephybun added a commit that referenced this pull request Aug 10, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants