New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Resource:] azurerm_databricks_workspace_root_dbfs_customer_managed_key
- deprecate azurerm_databricks_workspace_customer_managed_key
#22579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WodansSon
changed the title
[New Resource:] Jul 21, 2023
azurerm_databricks_workspace_customer_managed_key
- Remove import check for Root DBFS
keyazurerm_databricks_workspace_root_dbfs_customer_managed_key
- deprecate azurerm_databricks_workspace_customer_managed_key
katbyte
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌵
WodansSon
added a commit
that referenced
this pull request
Aug 22, 2023
katbyte
added a commit
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the updated
2023-02-01
version of the Databricks API the field this resource controls/wraps has been re-purposed to manage theroot DBFS
encryption key.Given the above mentioned changes in the API, this PR will deprecate the old Databricks CMK resource in favor of the same resource but being renamed to bring its naming more into alignment with it's intended purpose. (e.g., managing the
Root DBFS
CMK encryption key).(fixes: #22394)