Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_spring_cloud_configuration_service - support for the ca_certificate_id property #22814

Conversation

ms-henglu
Copy link
Contributor

No description provided.

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment around the documentation for this field, but this otherwise LGTM 👍

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@tombuildsstuff tombuildsstuff added this to the v3.69.0 milestone Aug 7, 2023
@tombuildsstuff
Copy link
Member

@ms-henglu the tests are repeatedly returning an error:

 Error: waiting for creation/update of Spring Cloud Configuration Service: (Configuration Service Name "default" / Spring Name "acctest-sc-230807045734471977" / Resource Group "acctestRG-spring-230807045734471977"): Code="CreateOrUpdateAcsFailed" Message="CreateOrUpdateAcsFailed"

Is additional configuration needed for this?

@ms-henglu
Copy link
Contributor Author

Hi @tombuildsstuff ,

Thanks for the heads up! I've updated this PR, and the tests are passing:
image

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu LGTM 🌟

@stephybun stephybun merged commit d11bb17 into hashicorp:main Aug 7, 2023
23 checks passed
stephybun added a commit that referenced this pull request Aug 7, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants