rename azurerm_graph_account to azurerm_graph_services_account

[teowa]

There is request from service team that the resource should be called graph_services_account.

[katbyte]

this is a breaking change as is?, we cannot just rename the resource and break users who may be using it. you will need to alias the resources and deprecate the old ones to be removed in 4.0

[teowa]

this is a breaking change as is?, we cannot just rename the resource and break users who may be using it. you will need to alias the resources and deprecate the old ones to be removed in 4.0

The old one is still usable before 4.0, I have also add a test for this.

[teowa]

--- PASS: TestAccGraphAccount (711.63s)
    --- PASS: TestAccGraphAccount/legacyAccount (143.91s)
        --- PASS: TestAccGraphAccount/legacyAccount/basic (143.91s)
    --- PASS: TestAccGraphAccount/account (567.73s)
        --- PASS: TestAccGraphAccount/account/basic (83.13s)
        --- PASS: TestAccGraphAccount/account/update (205.09s)
        --- PASS: TestAccGraphAccount/account/complete (140.44s)
        --- PASS: TestAccGraphAccount/account/requiresImport (139.06s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/graphservices 711.668s

[teowa]

Hi team, can we merge this earlier for few customer has started using the resource.

[stephybun]

Thanks @teowa LGTM 🎉

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.