Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_windows_web_app - prevent a panic with the auto_heal.triggers property #23812

Merged
merged 1 commit into from Nov 7, 2023
Merged

azurerm_windows_web_app - prevent a panic with the auto_heal.triggers property #23812

merged 1 commit into from Nov 7, 2023

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Nov 7, 2023 •
edited

fixes #23739

mbfrahry
mbfrahry approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@katbyte katbyte merged commit b36aa02 into main Nov 7, 2023
20 checks passed
@katbyte katbyte deleted the kt/panic branch November 7, 2023 20:54
@github-actions github-actions bot added this to the v3.80.0 milestone Nov 7, 2023
@calebak404 calebak404 mentioned this pull request Nov 7, 2023
Closed
1 task
@calebak404
Copy link

does not address if autoHeal.Actions is empty

@katbyte
Copy link
Collaborator Author

katbyte commented Nov 8, 2023

thanks for pointing that out, opened #23836 to fix actions too

@calebak404
Copy link

fwiw #23740 already does this

@calebak404 calebak404 mentioned this pull request Nov 10, 2023
Closed
@katbyte katbyte changed the title fix panic with web auto heal settings azurerm_windows_web_app - prevent a panic in the auto_heal block Dec 6, 2023
@katbyte katbyte changed the title azurerm_windows_web_app - prevent a panic in the auto_heal block azurerm_windows_web_app - prevent a panic with the auto_heal.triggers property Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
service/app-service size/XS
Projects
None yet
Milestone
v3.80.0
Development

Successfully merging this pull request may close these issues.

kernel panic in windows_web_app auto_heal settings
3 participants
@katbyte @calebak404 @mbfrahry