Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data source: azurerm_monitor_workspace #23928

Merged

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Nov 17, 2023

Fixes #23905

$ TF_ACC=1 go test -v ./internal/services/monitor -timeout=1000m -run='TestAccMonitorWorkspaceDataSourceDataSource_complete'
=== RUN   TestAccMonitorWorkspaceDataSourceDataSource_complete
=== PAUSE TestAccMonitorWorkspaceDataSourceDataSource_complete
=== CONT  TestAccMonitorWorkspaceDataSourceDataSource_complete
--- PASS: TestAccMonitorWorkspaceDataSourceDataSource_complete (164.92s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/monitor	166.554s

@favoretti
Copy link
Collaborator Author

image

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @favoretti.

Overall this looks good, but we should define a data source model and use that when encoding/decoding. Once that's done this should be good to go!

internal/services/monitor/monitor_workspace_data_source.go Outdated Show resolved Hide resolved
internal/services/monitor/monitor_workspace_data_source.go Outdated Show resolved Hide resolved
website/docs/d/monitor_workspace.html.markdown Outdated Show resolved Hide resolved
website/docs/d/monitor_workspace.html.markdown Outdated Show resolved Hide resolved
favoretti and others added 2 commits November 20, 2023 17:16
Co-authored-by: stephybun <steph@hashicorp.com>
Co-authored-by: stephybun <steph@hashicorp.com>
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favoretti LGTM 👍

@stephybun stephybun merged commit ab26b85 into hashicorp:main Nov 21, 2023
23 checks passed
@github-actions github-actions bot added this to the v3.82.0 milestone Nov 21, 2023
osfidelity pushed a commit to fidelity-contributions/hashicorp-terraform-provider-azurerm-archive that referenced this pull request Nov 22, 2023
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Nov 24, 2023
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>&#34;hashicorp/azurerm&#34; updated from &#34;3.81.0&#34; to
&#34;3.82.0&#34; in file &#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.82.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.82.0&#xA;FEATURES:&#xA;&#xA;*
New Data Source: `azurerm_monitor_workspace`
([#23928](https://github.com/hashicorp/terraform-provider-azurerm/issues/23928))&#xA;*
New Resource: `azurerm_application_load_balancer_subnet_association`
([#23628](https://github.com/hashicorp/terraform-provider-azurerm/issues/23628))&#xA;&#xA;ENHANCEMENTS:&#xA;&#xA;*
dependencies: updating to `v0.20231117.1130141` of
`github.com/hashicorp/go-azure-sdk`
([#23945](https://github.com/hashicorp/terraform-provider-azurerm/issues/23945))&#xA;*
`azurestackhci`: updating to API Version `2023-08-01`
([#23939](https://github.com/hashicorp/terraform-provider-azurerm/issues/23939))&#xA;*
`dashboard`: updating to API Version `2023-09-01`
([#23929](https://github.com/hashicorp/terraform-provider-azurerm/issues/23929))&#xA;*
`hpccache`: updating to API version `2023-05-01`
([#24005](https://github.com/hashicorp/terraform-provider-azurerm/issues/24005))&#xA;*
`mssql`: updating resources using `hashicorp/go-azure-sdk` to API
Version `2023-02-01-preview`
([#23721](https://github.com/hashicorp/terraform-provider-azurerm/issues/23721))&#xA;*
`templatespecversions`: updating to API Version `2022-02-01`
([#24007](https://github.com/hashicorp/terraform-provider-azurerm/issues/24007))&#xA;*
Data Source: `azurerm_template_spec_version` - refactoring to use
`hashicorp/go-azure-sdk`
([#24007](https://github.com/hashicorp/terraform-provider-azurerm/issues/24007))&#xA;*
`azurerm_cosmosdb_postgresql_cluster` -
`coordinator_storage_quota_in_mb` and `coordinator_vcore_count` are no
longer required for read replicas
([#23928](https://github.com/hashicorp/terraform-provider-azurerm/issues/23928))&#xA;*
`azurerm_dashboard_grafana` - `sku` can now be set to `Essential`
([#23934](https://github.com/hashicorp/terraform-provider-azurerm/issues/23934))&#xA;*
`azurerm_gallery_application_version` - add support for the
`config_file`, `package_file` and `target_region.exclude_from_latest`
properties
([#23816](https://github.com/hashicorp/terraform-provider-azurerm/issues/23816))&#xA;*
`azurerm_hdinsight_hadoop_cluster` - `script_actions` is no longer Force
New
([#23888](https://github.com/hashicorp/terraform-provider-azurerm/issues/23888))&#xA;*
`azurerm_hdinsight_hbase_cluster` - `script_actions` is no longer Force
New
([#23888](https://github.com/hashicorp/terraform-provider-azurerm/issues/23888))&#xA;*
`azurerm_hdinsight_interactive_query_cluster` - `script_actions` is no
longer Force New
([#23888](https://github.com/hashicorp/terraform-provider-azurerm/issues/23888))&#xA;*
`azurerm_hdinsight_kafka_cluster` - `script_actions` is no longer Force
New
([#23888](https://github.com/hashicorp/terraform-provider-azurerm/issues/23888))&#xA;*
`azurerm_hdinsight_spark_cluster` - `script_actions` is no longer Force
New
([#23888](https://github.com/hashicorp/terraform-provider-azurerm/issues/23888))&#xA;*
`azurerm_kubernetes_cluster` - add support for the `gpu_instance`
property
([#23887](https://github.com/hashicorp/terraform-provider-azurerm/issues/23887))&#xA;*
`azurerm_kubernetes_cluster_node_pool` - add support for the
`gpu_instance` property
([#23887](https://github.com/hashicorp/terraform-provider-azurerm/issues/23887))&#xA;*
`azurerm_log_analytics_workspace` - add support for the `identity`
property
([#23864](https://github.com/hashicorp/terraform-provider-azurerm/issues/23864))&#xA;*
`azurerm_linux_function_app` - add support for dotnet 8
([#23638](https://github.com/hashicorp/terraform-provider-azurerm/issues/23638))&#xA;*
`azurerm_linux_function_app_slot` - add support for dotnet 8
([#23638](https://github.com/hashicorp/terraform-provider-azurerm/issues/23638))&#xA;*
`azurerm_managed_lustre_file_system` - export attribute `mgs_address`
([#23942](https://github.com/hashicorp/terraform-provider-azurerm/issues/23942))&#xA;*
`azurerm_mssql_database` - support for Hyperscale SKUs
([#23974](https://github.com/hashicorp/terraform-provider-azurerm/issues/23974))&#xA;*
`azurerm_mssql_database` - refactoring to use `hashicorp/go-azure-sdk`
([#23721](https://github.com/hashicorp/terraform-provider-azurerm/issues/23721))&#xA;*
`azurerm_mssql_server` - refactoring to use `hashicorp/go-azure-sdk`
([#23721](https://github.com/hashicorp/terraform-provider-azurerm/issues/23721))&#xA;*
`azurerm_shared_image` - add support for `trusted_launch_supported`
([#23781](https://github.com/hashicorp/terraform-provider-azurerm/issues/23781))&#xA;*
`azurerm_spring_cloud_container_deployment` - add support for the
`application_performance_monitoring_ids` property
([#23862](https://github.com/hashicorp/terraform-provider-azurerm/issues/23862))&#xA;*
`azurerm_spring_cloud_customized_accelerator` - add support for the
`accelerator_type` and `path` properties
([#23797](https://github.com/hashicorp/terraform-provider-azurerm/issues/23797))&#xA;*
`azurerm_point_to_site_vpn_gateway` - allow multiple
`connection_configurations` blocks
([#23936](https://github.com/hashicorp/terraform-provider-azurerm/issues/23936))&#xA;*
`azurerm_private_dns_cname_record` - `ttl` can now be set to 0
([#23918](https://github.com/hashicorp/terraform-provider-azurerm/issues/23918))&#xA;*
`azurerm_windows_function_app` - add support for dotnet 8
([#23638](https://github.com/hashicorp/terraform-provider-azurerm/issues/23638))&#xA;*
`azurerm_windows_function_app_slot` - add support for dotnet 8
([#23638](https://github.com/hashicorp/terraform-provider-azurerm/issues/23638))&#xA;&#xA;BUG
FIXES:&#xA;* `azurerm_api_management` - correct a bug with additional
location zones within the `additional_location` block
([#23943](https://github.com/hashicorp/terraform-provider-azurerm/issues/23943))&#xA;*
`azurerm_dev_test_linux_virtual_machine` - `storage_type` is now
ForceNew to match the updated API behaviour
([#23973](https://github.com/hashicorp/terraform-provider-azurerm/issues/23973))&#xA;*
`azurerm_dev_test_windows_virtual_machine` - `storage_type` is now
ForceNew to match the updated API behaviour
([#23973](https://github.com/hashicorp/terraform-provider-azurerm/issues/23973))&#xA;*
`azurerm_disk_encryption_set` - resource will recreate if `identity`
changes from `SystemAssigned` to `UserAssigned`
([#23904](https://github.com/hashicorp/terraform-provider-azurerm/issues/23904))&#xA;*
`azurerm_eventhub_cluster`: `sku_name` is no longer ForceNew
([#24009](https://github.com/hashicorp/terraform-provider-azurerm/issues/24009))&#xA;*
`azurerm_firewall` - recasing the value for `firewall_policy_id` to
workaround the API returning the incorrect casing
([#23993](https://github.com/hashicorp/terraform-provider-azurerm/issues/23993))&#xA;*
`azurerm_security_center_subscription_pricing` - fix a bug preventing
removal of `extensions` and downgrading `tier` to `Free`
([#23821](https://github.com/hashicorp/terraform-provider-azurerm/issues/23821))&#xA;*
`azurerm_windows_web_app` - fix an issue of incorrect application stack
settings during update
([#23372](https://github.com/hashicorp/terraform-provider-azurerm/issues/23372))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/896/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_monitor_workspace data source
2 participants