Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_cosmosdb_postgresql_cluster - Mark coordinator_storage_quota_in_mb and coordinator_vcore_count as optional #23938

Merged

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Nov 17, 2023

fixes #23923

image

…in_mb and coordinator_vcore_count as optional
@@ -263,10 +263,11 @@ resource "azurerm_cosmosdb_postgresql_cluster" "test2" {
source_location = azurerm_cosmosdb_postgresql_cluster.test.location
source_resource_id = azurerm_cosmosdb_postgresql_cluster.test.id
point_in_time_in_utc = azurerm_cosmosdb_postgresql_cluster.test.earliest_restore_time
node_count = 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have we removed node count here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't remove "node_count". It's just the format adjusting.

@neil-yechenwei
Copy link
Contributor Author

@stephybun , I replied your comment. Please take another look. Thanks.

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei LGTM 👍

@stephybun stephybun merged commit 2b6329e into hashicorp:main Nov 21, 2023
25 checks passed
@github-actions github-actions bot added this to the v3.82.0 milestone Nov 21, 2023
osfidelity pushed a commit to fidelity-contributions/hashicorp-terraform-provider-azurerm-archive that referenced this pull request Nov 22, 2023
Copy link

github-actions bot commented May 6, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants