azurerm_orchestrated_virtual_machine_scale_set - fix update errors when running Hotpatch-compatible images
#24335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katbyte
added a commit
that referenced
this pull request
Jan 3, 2024
dduportal
pushed a commit
to jenkins-infra/azure
that referenced
this pull request
Jan 6, 2024
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
<h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
<summary>Update Terraform lock file</summary>
<p>"hashicorp/azurerm" updated from "3.85.0" to
"3.86.0" in file ".terraform.lock.hcl"</p>
<details>
<summary>3.86.0</summary>
<pre>Changelog retrieved
from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.86.0
FEATURES:

*
New Data Source: `azurerm_dashboard_grafana`
([#24243](https://github.com/hashicorp/terraform-provider-azurerm/issues/24243))
*
New Resource: `azurerm_log_analytics_workspace_table`
([#24229](https://github.com/hashicorp/terraform-provider-azurerm/issues/24229))
*
New Resource: `azurerm_automation_powershell72_module`
([#23980](https://github.com/hashicorp/terraform-provider-azurerm/issues/23980))
*
New Resource: `azurerm_data_factory_credential_user_managed_identity`
([#24307](https://github.com/hashicorp/terraform-provider-azurerm/issues/24307))

ENHANCEMENTS:

*
dependencies: updating to `v0.20231215.1114251` of
`hashicorp/go-azure-sdk`
([#24251](https://github.com/hashicorp/terraform-provider-azurerm/issues/24251))
*
dependencies: `azurerm_spring_cloud_api_portal` - update to use
`hashicorp/go-azure-sdk`
([#24321](https://github.com/hashicorp/terraform-provider-azurerm/issues/24321))
*
Data Source: `azurerm_kusto_cluster` - now exports the `identity` block
([#24314](https://github.com/hashicorp/terraform-provider-azurerm/issues/24314))
*
`azurerm_data_protection_backup_policy_postgresql` - support for the
`time_zone` property
([#24312](https://github.com/hashicorp/terraform-provider-azurerm/issues/24312))
*
`azurerm_data_protection_backup_policy_disk` - support for the
`time_zone` property
([#24312](https://github.com/hashicorp/terraform-provider-azurerm/issues/24312))
*
`azurerm_key_vault_managed_hardware_security_module` -the `tags`
property can now be updated
([#24333](https://github.com/hashicorp/terraform-provider-azurerm/issues/24333))
*
`azurerm_logic_app_standard` - support for the
`site_config.0.public_network_access_enabled` property
([#24257](https://github.com/hashicorp/terraform-provider-azurerm/issues/24257))
*
`azurerm_log_analytics_workspace_table` - support for the `plan`
property
([#24341](https://github.com/hashicorp/terraform-provider-azurerm/issues/24341))
*
`azurerm_linux_web_app` - support the value `20-lts` for the
`node_version` property
([#24289](https://github.com/hashicorp/terraform-provider-azurerm/issues/24289))
*
`azurerm_recovery_services_vault` - support creation with immutability
set to locked
([#23806](https://github.com/hashicorp/terraform-provider-azurerm/issues/23806))
*
`azurerm_spring_cloud_service` - support for the `sku_tier` property
([#24103](https://github.com/hashicorp/terraform-provider-azurerm/issues/24103))

BUG
FIXES:

* Data Source: `azurerm_role_definition` - correctly
export the `role_definition_id` attribute
([#24320](https://github.com/hashicorp/terraform-provider-azurerm/issues/24320))
*
`azurerm_bot_service` - fixing a bug where
`public_network_access_enabled` was always set to `true`
([#24255](https://github.com/hashicorp/terraform-provider-azurerm/issues/24255))
*
`azurerm_bot_service_azure_bot` - `tags` can now be updated
([#24332](https://github.com/hashicorp/terraform-provider-azurerm/issues/24332))
*
`azurerm_cosmosdb_account` - fix validation for the `ip_range_filter`
property
([#24306](https://github.com/hashicorp/terraform-provider-azurerm/issues/24306))
*
`azurerm_linux_virtual_machine` - the
`additional_capabilities.0.ultra_ssd_enabled` can now be changed during
the update
([#24274](https://github.com/hashicorp/terraform-provider-azurerm/issues/24274))
*
`azurerm_logic_app_standard` - update the default value of `version`
from `~3` which is no longer supported to `~4`
([#24134](https://github.com/hashicorp/terraform-provider-azurerm/issues/24134))
*
`azurerm_logic_app_standard` - fix a crash when setting the default
`version` 4.0 flag
([#24322](https://github.com/hashicorp/terraform-provider-azurerm/issues/24322))
*
`azurerm_iothub_device_update_account` - changing the `sku` property now
creates a new resource
([#24324](https://github.com/hashicorp/terraform-provider-azurerm/issues/24324))
*
`azurerm_iothub` - prevent an inconsistant value after an apply
([#24326](https://github.com/hashicorp/terraform-provider-azurerm/issues/24326))
*
`azurerm_orchestrated_virtual_machine_scale_set` - correctly update the
resource when hotpatch is enabled
([#24335](https://github.com/hashicorp/terraform-provider-azurerm/issues/24335))
*
`azurerm_windows_virtual_machine` - the
`additional_capabilities.0.ultra_ssd_enabled` can now be changed during
the update
([#24274](https://github.com/hashicorp/terraform-provider-azurerm/issues/24274))
*
`azurerm_scheduled_query_rules_alert` - changing the `data_source_id`
now creates a new resource
([#24327](https://github.com/hashicorp/terraform-provider-azurerm/issues/24327))
*
`azurerm_scheduled_query_rules_log` - changing the `data_source_id` now
creates a new resource
([#24327](https://github.com/hashicorp/terraform-provider-azurerm/issues/24327))


</pre>
</details>
</details>
<a
href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/985/">Jenkins
pipeline link</a>
</action>
</Actions>
---
<table>
<tr>
<td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
</td>
<td>
<p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
</p>
<details><summary>Options:</summary>
<br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
<ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
</ul>
<p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
</p>
</details>
</td>
</tr>
</table>
Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to Reproduce
azurerm_orchestrated_virtual_machine_scale_setinstance with a hotpatch-compatible imagetagsvalue in .tfterraform applyto update theazurerm_orchestrated_virtual_machine_scale_setresourceExpected Behaviour
terraform applyruns successfullyActual Behaviour
Azure Service returns error of
"'EnableHotpatching' must be set to 'true' on Virtual Machine Scale Sets running Hotpatch-compatible images."Root Cause
When running Hotpatch-compatible images, the PATCH API requires
EnableHotpatching=trueset in the message body. But the provider sends an emptypatchSettings.Test Result
=== RUN TestAccOrchestratedVirtualMachineScaleSet_AutomaticVMGuestPatchingHotpatchingEnabledWindows
=== PAUSE TestAccOrchestratedVirtualMachineScaleSet_AutomaticVMGuestPatchingHotpatchingEnabledWindows
=== CONT TestAccOrchestratedVirtualMachineScaleSet_AutomaticVMGuestPatchingHotpatchingEnabledWindows
--- PASS: TestAccOrchestratedVirtualMachineScaleSet_AutomaticVMGuestPatchingHotpatchingEnabledWindows (289.74s)
PASS