Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster - support updating default_node_pool.linux_os_config.sysctl_config #24397

Conversation

ms-henglu
Copy link
Contributor

The sysctl_config in the default_node_pool is marked as force new, but the default node pool could be updated by cycling. This PR separate the sysctl_config schema into two schema, one is used in default node pool which supports update, one is used in other node pool which doesn't support update.

@ms-henglu ms-henglu marked this pull request as ready for review January 5, 2024 06:18
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🪖

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🪖

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @ms-henglu. Can you please add a standalone test that updates a value in the linux_os_config.sysctl_config block?

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu LGTM 👍

@stephybun stephybun merged commit 5352723 into hashicorp:main Jan 11, 2024
33 checks passed
@github-actions github-actions bot added this to the v3.87.0 milestone Jan 11, 2024
stephybun added a commit that referenced this pull request Jan 11, 2024
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Jan 17, 2024
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>&#34;hashicorp/azurerm&#34; updated from &#34;3.86.0&#34; to
&#34;3.87.0&#34; in file &#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.87.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.87.0&#xA;ENHANCEMENTS:&#xA;&#xA;*
dependencies: updating to `v0.20240112.1095456` of
`github.com/hashicorp/go-azure-sdk` [GH-24477]&#xA;* dependencies:
updating to `v0.65.1` of `github.com/hashicorp/go-azure-helpers`
[GH-24479]&#xA;* `kusto`: updating to use the base layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
[GH-24477]&#xA;* `azurerm_container_group` - support for the `priority`
property [GH-24374]&#xA;* Data Source: `azurerm_application_gateway` -
support for the `trusted_client_certificate.data` property
[GH-24474]&#xA;&#xA;## 3.87.0 (January 11,
2024)&#xA;&#xA;FEATURES:&#xA;&#xA;* New Data Source:
`azurerm_network_manager`
([#24398](https://github.com/hashicorp/terraform-provider-azurerm/issues/24398))&#xA;*
New Resource:
`azurerm_security_center_server_vulnerability_assessments_setting`
([#24299](https://github.com/hashicorp/terraform-provider-azurerm/issues/24299))&#xA;&#xA;ENHANCEMENTS:&#xA;&#xA;*
dependencies: updating to `v0.20240111.1094251` of
`github.com/hashicorp/go-azure-sdk`
([#24463](https://github.com/hashicorp/terraform-provider-azurerm/issues/24463))&#xA;*
Data Source: `azurerm_mssql_database` - support for `identity`,
`transparent_data_encryption_enabled`,
`transparent_data_encryption_key_vault_key_id` and
`transparent_data_encryption_key_automatic_rotation_enabled`
([#24412](https://github.com/hashicorp/terraform-provider-azurerm/issues/24412))&#xA;*
Data Source: `azurerm_mssql_server` - support for
`transparent_data_encryption_key_vault_key_id`
([#24412](https://github.com/hashicorp/terraform-provider-azurerm/issues/24412))&#xA;*
`machinelearning`: updating to API Version `2023-10-01`
([#24416](https://github.com/hashicorp/terraform-provider-azurerm/issues/24416))&#xA;*
`paloaltonetworks`: updating to API Version `2023-09-01`
([#24290](https://github.com/hashicorp/terraform-provider-azurerm/issues/24290))&#xA;*
`azurerm_container_app` - update create time validations for
`ingress.0.traffic_weight`
([#24042](https://github.com/hashicorp/terraform-provider-azurerm/issues/24042))&#xA;*
`azurerm_container_app`- support for the `ip_security_restriction` block
([#23870](https://github.com/hashicorp/terraform-provider-azurerm/issues/23870))&#xA;*
`azurerm_kubernetes_cluster` - properties in
`default_node_pool.linux_os_config.sysctl_config` are now updateable via
node pool cycling
([#24397](https://github.com/hashicorp/terraform-provider-azurerm/issues/24397))&#xA;*
`azurerm_linux_web_app` - support the `VS2022` value for the
`remote_debugging_version` property
([#24407](https://github.com/hashicorp/terraform-provider-azurerm/issues/24407))&#xA;*
`azurerm_mssql_database` - support for `identity`,
`transparent_data_encryption_key_vault_key_id` and
`transparent_data_encryption_key_automatic_rotation_enabled`
([#24412](https://github.com/hashicorp/terraform-provider-azurerm/issues/24412))&#xA;*
`azurerm_postgres_flexible_server` - the `sku_name` property now
supports being set to `MO_Standard_E96ds_v5`
([#24367](https://github.com/hashicorp/terraform-provider-azurerm/issues/24367))&#xA;*
`azurerm_role_assignment` - support for the `principal_type` property
([#24271](https://github.com/hashicorp/terraform-provider-azurerm/issues/24271))&#xA;*
`azurerm_windows_web_app` - support the `VS2022` value for the
`remote_debugging_version` property
([#24407](https://github.com/hashicorp/terraform-provider-azurerm/issues/24407))&#xA;*
`azurerm_cdn_frontdoor_firewall_policy` - support for
`request_body_check_enabled` property
([#24406](https://github.com/hashicorp/terraform-provider-azurerm/issues/24406))&#xA;&#xA;BUG
FIXES:&#xA;&#xA;* Data Source: `azurerm_role_definition` - fix
`role_definition_id`
([#24418](https://github.com/hashicorp/terraform-provider-azurerm/issues/24418))&#xA;*
`azurerm_api_management` - the `sku_name` property can now be updated
([#24431](https://github.com/hashicorp/terraform-provider-azurerm/issues/24431))&#xA;*
`azurerm_arc_kubernetes_flux_configuration` - prevent a bug where
certain sensitive properties for `bucket` and `git_repository` were
being overwritten after an update to the resource is made
([#24066](https://github.com/hashicorp/terraform-provider-azurerm/issues/24066))&#xA;*
`azurerm_kubernetes_flux_configuration` - prevent a bug where certain
sensitive properties for `bucket` and `git_repository` were being
overwritten after an update to the resource is made
([#24066](https://github.com/hashicorp/terraform-provider-azurerm/issues/24066))&#xA;*
`azure_linux_web_app` - prevent a bug in App Service processing of
`application_stack` in updates to `site_config`
([#24424](https://github.com/hashicorp/terraform-provider-azurerm/issues/24424))&#xA;*
`azure_linux_web_app_slot` - Fix bug in App Service processing of
`application_stack` in updates to `site_config`
([#24424](https://github.com/hashicorp/terraform-provider-azurerm/issues/24424))&#xA;*
`azurerm_network_manager_deployment` - update creation wait logic to
better tolerate the api returning not found
([#24330](https://github.com/hashicorp/terraform-provider-azurerm/issues/24330))&#xA;*
`azurerm_virtual_machine_data_disk_attachment` - do not update
applications profile with disks
([#24145](https://github.com/hashicorp/terraform-provider-azurerm/issues/24145))&#xA;*
`azure_windows_web_app` - prevent a bug in App Service processing of
`application_stack` in updates to `site_config`
([#24424](https://github.com/hashicorp/terraform-provider-azurerm/issues/24424))&#xA;*
`azure_windows_web_app_slot` - prevent a bug in App Service processing
of `application_stack` in updates to `site_config`
([#24424](https://github.com/hashicorp/terraform-provider-azurerm/issues/24424))&#xA;*
`azurerm_maintenance_configuration` - set the `reboot` property in
flatten from `AlwaysReboot` to `Always`
([#24376](https://github.com/hashicorp/terraform-provider-azurerm/issues/24376))&#xA;*
`azurerm_container_app_environment` - the `workload_profile` property
can now be updated
([#24409](https://github.com/hashicorp/terraform-provider-azurerm/issues/24409))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/1004/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants