Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_public_ip: ensure all fields have a value #2448

Merged
merged 2 commits into from Dec 7, 2018
Merged

azurerm_public_ip: ensure all fields have a value #2448

merged 2 commits into from Dec 7, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Dec 5, 2018

Fixes #2440

@katbyte katbyte added this to the 1.20.0 milestone Dec 5, 2018
@ghost ghost added the size/M label Dec 5, 2018
WodansSon
WodansSon reviewed Dec 5, 2018
View reviewed changes
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katbyte This mostly looks good to go, however I left a couple of very minor comments.

azurerm/data_source_public_ip.go Show resolved Hide resolved
tombuildsstuff
tombuildsstuff approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@katbyte katbyte merged commit f454afa into master Dec 7, 2018
@katbyte katbyte deleted the publicip/datasource branch December 7, 2018 16:40
katbyte added a commit that referenced this pull request Dec 7, 2018
@katbyte
Update CHANGELOG.md to include #2448
379b6ca
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@WodansSon WodansSon WodansSon left review comments

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug service/public-ip size/M
Projects
None yet
Milestone
v1.20.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@katbyte @tombuildsstuff @WodansSon