Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple partitions in azurerm_servicebus_namespace #24597

Closed
1 task done
Simonzhaohui opened this issue Jan 23, 2024 · 9 comments · Fixed by #24676
Closed
1 task done

Support for multiple partitions in azurerm_servicebus_namespace #24597

Simonzhaohui opened this issue Jan 23, 2024 · 9 comments · Fixed by #24676

Comments

@Simonzhaohui
Copy link

Simonzhaohui commented Jan 23, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment and review the contribution guide to help.

Description

When I would like to create azure service bus namespace with Premium sku, I can't set multiple partitions, like azure portal or CLI, example: parameter --premium-partitions with az servicebus namespace create.

The Partition count of Premium service bus namespace is 1, then I can't set enable_partitioning for azurerm_servicebus_topic

azurerm version: 3.86.0

New or Affected Resource(s)/Data Source(s)

azurerm_servicebus_namespace

Potential Terraform Configuration

resource "azurerm_servicebus_namespace" "sb" {
  ...
  sku                           = "Premium"
  capacity                      = 2
  partitions                    = 2
  ... 

This partitions is only for Premium

References

https://learn.microsoft.com/en-us/azure/service-bus-messaging/enable-partitions-premium

@xiaxyi
Copy link
Contributor

xiaxyi commented Jan 24, 2024

Thanks @Simonzhaohui for raising this issue, let me check the feature and add it to the backlog once confirmed.

@xiaxyi
Copy link
Contributor

xiaxyi commented Jan 25, 2024

Hi @Simonzhaohui , the property is added in api version 2022-10-01-preview while azurerm servicebus resource provider is currently using 2022-01-01-preview. Let me raise a PR to upgrade the api version then add this property. Any update will be shared here.

@Simonzhaohui
Copy link
Author

@xiaxyi Appreciated for your support !

@xiaxyi
Copy link
Contributor

xiaxyi commented Jan 26, 2024

Link API upgrade PR:#24650

@xiaxyi
Copy link
Contributor

xiaxyi commented Jan 29, 2024

@Simonzhaohui Thanks for your patience, you can subscribe the linked PR for progress.

@chrispellett
Copy link

Does the linked PR (that was released in v3.90.0) have everything required to support multiple partitions on premium service bus namespaces?

The documentation doesn't mention what the property name to use is.

@xiaxyi
Copy link
Contributor

xiaxyi commented Feb 7, 2024

@chrispellett Would you mind be more specific about "everything required to support multiple partitions on premium service bus namespaces"? About the property part, if my understanding is correct, are you talking about the api property? The property that this pr covered is
premiumMessagingPartitions

@chrispellett
Copy link

Sure, sorry I wasn't clear before.

When I refer to the namespace resource documentation for v3.90.0, I don't see a property related to the partition count: https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/servicebus_namespace

I'm not sure if the documentation aspect is part of the work to close this particular issue or not.

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants