`azurerm_servicebus_namespace` - upgrade api version to `2022-10-01-preview` #24650

xiaxyi · 2024-01-26T06:52:45Z

To support the property premiumMessagingPartitions

acc tests:

--- PASS: TestAccAzureRMServiceBusNamespace_premiumCapacity (125.18s)
--- PASS: TestAccAzureRMServiceBusNamespace_basicCapacity (125.77s)
--- PASS: TestAccAzureRMServiceBusNamespace_readDefaultKeys (304.98s)
--- PASS: TestAccAzureRMServiceBusNamespace_basic (331.77s)
--- PASS: TestAccAzureRMServiceBusNamespace_complete (347.25s)
--- PASS: TestAccAzureRMServiceBusNamespace_requiresImport (356.15s)
--- PASS: TestAccAzureRMServiceBusNamespace_minimumTLSUpdate (386.43s)
--- PASS: TestAccAzureRMServiceBusNamespace_updateSku (455.25s)
--- PASS: TestAccAzureRMServiceBusNamespace_endpoint (343.76s)
--- PASS: TestAccAzureRMServiceBusNamespace_publicNetworkAccessUpdate (290.33s)
--- PASS: TestAccAzureRMServiceBusNamespace_premium (439.91s)
--- PASS: TestAccAzureRMServiceBusNamespace_zoneRedundant (437.68s)
--- PASS: TestAccAzureRMServiceBusNamespace_networkRuleSet (684.28s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/servicebus    2618.649s

tombuildsstuff

Looks like there's still one reference to the older API version?

tombuildsstuff · 2024-01-26T10:38:24Z

vendor/modules.txt

@@ -928,6 +928,7 @@ github.com/hashicorp/go-azure-sdk/resource-manager/servicebus/2021-06-01-preview
 github.com/hashicorp/go-azure-sdk/resource-manager/servicebus/2021-06-01-preview/topics
 github.com/hashicorp/go-azure-sdk/resource-manager/servicebus/2021-06-01-preview/topicsauthorizationrule
 github.com/hashicorp/go-azure-sdk/resource-manager/servicebus/2022-01-01-preview/namespaces


Looks like the older API Version is still used elsewhere in the codebase? When updating API versions you can use this tool to update all references across the provider - like so:

go build . && ./update-api-version -service="servicebus" -old-api-version="2022-01-01-preview" -new-api-version="2022-10-01-preview"

Comparing the result of that command verses the files changed in this PR, it appears there's still a reference to the older API Version in the State Migration:

modified: ../../services/servicebus/client/client.go modified: ../../services/servicebus/internal.go modified: ../../services/servicebus/migration/namespace_network_rule_set.go modified: ../../services/servicebus/servicebus_namespace_authorization_rule_data_source.go modified: ../../services/servicebus/servicebus_namespace_authorization_rule_resource.go modified: ../../services/servicebus/servicebus_namespace_data_source.go modified: ../../services/servicebus/servicebus_namespace_disaster_recovery_config_data_source.go modified: ../../services/servicebus/servicebus_namespace_network_rule_set_resource.go modified: ../../services/servicebus/servicebus_namespace_network_rule_set_resource_test.go modified: ../../services/servicebus/servicebus_namespace_resource.go modified: ../../services/servicebus/servicebus_namespace_resource_test.go modified: ../../services/servicebus/servicebus_queue_authorization_rule_resource.go modified: ../../services/servicebus/servicebus_queue_data_source.go modified: ../../services/servicebus/servicebus_queue_resource.go modified: ../../services/servicebus/servicebus_topic_authorization_rule_resource.go modified: ../../services/servicebus/servicebus_topic_data_source.go modified: ../../services/servicebus/servicebus_topic_resource.go

Mind fixing that one?

xiaxyi · 2024-01-26T11:47:14Z

Thanks @tombuildsstuff ! Nice tool, noted. I updated the code. Let me know if you have any comment.

tombuildsstuff

LGTM 👍

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/azurerm" updated from "3.89.0" to "3.90.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.90.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.90.0
UPGRADE NOTES:

* provider - The provider will now automatically register the `AppConfiguration`, `DataFactory`, and `SignalRService` Resource Providers. When running Terraform with limited permissions, note that you [must disable automatic Resource Provider Registration and ensure that any Resource Providers Terraform requires are registered]([XXX](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs#skip_provider_registration)). ([#24645](https://github.com/hashicorp/terraform-provider-azurerm/issues/24645))
 
FEATURES:

* **New Data Source**: `azurerm_nginx_configuration` ([#24642](https://github.com/hashicorp/terraform-provider-azurerm/issues/24642))
* **New Data Source**: `azurerm_virtual_desktop_workspace` ([#24732](https://github.com/hashicorp/terraform-provider-azurerm/issues/24732))
* **New Resource**: `azurerm_kubernetes_fleet_update_strategy` ([#24328](https://github.com/hashicorp/terraform-provider-azurerm/issues/24328))
* **New Resource**: `azurerm_site_recovery_vmware_replicated_vm` ([#22477](https://github.com/hashicorp/terraform-provider-azurerm/issues/22477))
* **New Resource**: `azurerm_spring_cloud_new_relic_application_performance_monitoring` ([#24699](https://github.com/hashicorp/terraform-provider-azurerm/issues/24699))

ENHANCEMENTS:

* provider: registering the Resource Provider `Microsoft.AppConfiguration` ([#24645](https://github.com/hashicorp/terraform-provider-azurerm/issues/24645))
* provider: registering the Resource Provider `Microsoft.DataFactory` ([#24645](https://github.com/hashicorp/terraform-provider-azurerm/issues/24645))
* provider: registering the Resource Provider `Microsoft.SignalRService` ([#24645](https://github.com/hashicorp/terraform-provider-azurerm/issues/24645))
* provider: the Provider is now built using Go 1.21.6 ([#24653](https://github.com/hashicorp/terraform-provider-azurerm/issues/24653))
* dependencies: the dependency `github.com/hashicorp/go-azure-sdk` has been split into multiple Go Modules - and as such will be referred to by those paths going forwards ([#24636](https://github.com/hashicorp/terraform-provider-azurerm/issues/24636))
* dependencies: updating to ``v0.20240201.1064937` of `github.com/hashicorp/go-azure-sdk/resource-manager` ([#24738](https://github.com/hashicorp/terraform-provider-azurerm/issues/24738))
* dependencies: updating to `v0.20240201.1064937` of `github.com/hashicorp/go-azure-sdk/sdk` ([#24738](https://github.com/hashicorp/terraform-provider-azurerm/issues/24738))
* `appservice`: update to `go-azure-sdk` and API version `2023-01-01` ([#24688](https://github.com/hashicorp/terraform-provider-azurerm/issues/24688))
* `datafactory`: updating to use `tombuildsstuff/kermit` ([#24675](https://github.com/hashicorp/terraform-provider-azurerm/issues/24675))
* `hdinsight`: refactoring to use `github.com/hashicorp/go-azure-sdk/resource-manager` ([#24011](https://github.com/hashicorp/terraform-provider-azurerm/issues/24011))
* `hdinsight`: updating to API Version `2021-06-01` ([#24011](https://github.com/hashicorp/terraform-provider-azurerm/issues/24011))
* `loadbalancer`: updating to use `hashicorp/go-azure-sdk` ([#24291](https://github.com/hashicorp/terraform-provider-azurerm/issues/24291))
* `nginx`: updating to API Version `2023-09-01` ([#24640](https://github.com/hashicorp/terraform-provider-azurerm/issues/24640))
* `servicefabricmanagedcluster`: updating to use the base layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#24654](https://github.com/hashicorp/terraform-provider-azurerm/issues/24654))
* `springcloud`: updating to use API Version `2023-11-01-preview` ([#24690](https://github.com/hashicorp/terraform-provider-azurerm/issues/24690))
* `subscriptions`: refactoring to use `hashicorp/go-azure-sdk` ([#24663](https://github.com/hashicorp/terraform-provider-azurerm/issues/24663))
* Data Source: `azurerm_stream_analytics_job` - support for User Assigned Identities ([#24738](https://github.com/hashicorp/terraform-provider-azurerm/issues/24738))
* `azurerm_cosmosdb_account` - support for the `gremlin_database` and `tables_to_restore` properties ([#24627](https://github.com/hashicorp/terraform-provider-azurerm/issues/24627))
* `azurerm_bot_channel_email` - support for the `magic_code` property ([#23129](https://github.com/hashicorp/terraform-provider-azurerm/issues/23129))
* `azurerm_cosmosdb_account` - support for the `partition_merge_enabled` property ([#24615](https://github.com/hashicorp/terraform-provider-azurerm/issues/24615))
* `azurerm_mssql_managed_database` - support for the `immutable_backups_enabled` property ([#24745](https://github.com/hashicorp/terraform-provider-azurerm/issues/24745))
* `azurerm_mssql_database` - support for the `immutable_backups_enabled` property ([#24745](https://github.com/hashicorp/terraform-provider-azurerm/issues/24745))
* `azurerm_palo_alto_next_generation_firewall_virtual_hub_panorama` - support for the `trusted_address_ranges` property ([#24459](https://github.com/hashicorp/terraform-provider-azurerm/issues/24459))
* `azurerm_palo_alto_next_generation_firewall_virtual_network_local_rulestack` - support for the `trusted_address_ranges` property ([#24459](https://github.com/hashicorp/terraform-provider-azurerm/issues/24459))
* `azurerm_palo_alto_next_generation_firewall_virtual_network_panorama` - support for the `trusted_address_ranges` property ([#24459](https://github.com/hashicorp/terraform-provider-azurerm/issues/24459))
* `azurerm_servicebus_namespace` - updating to use API Version `2022-10-01-preview` ([#24650](https://github.com/hashicorp/terraform-provider-azurerm/issues/24650))
* `azurerm_spring_cloud_api_portal` - support for the `api_try_out_enabled` property ([#24696](https://github.com/hashicorp/terraform-provider-azurerm/issues/24696))
* `azurerm_spring_cloud_gateway` - support for the `local_response_cache_per_route` and `local_response_cache_per_instance` properties ([#24697](https://github.com/hashicorp/terraform-provider-azurerm/issues/24697))
* `azurerm_stream_analytics_job` - support for User Assigned Identities ([#24738](https://github.com/hashicorp/terraform-provider-azurerm/issues/24738))
* `azurerm_subscription` - refactoring to use `hashicorp/go-azure-sdk` to set tags on the subscription ([#24734](https://github.com/hashicorp/terraform-provider-azurerm/issues/24734))
* `azurerm_virtual_desktop_workspace` - correctly validate the `name` property ([#24668](https://github.com/hashicorp/terraform-provider-azurerm/issues/24668))


BUG FIXES:

* provider: skip registration for resource providers that are unavailable ([#24571](https://github.com/hashicorp/terraform-provider-azurerm/issues/24571))
* `azurerm_app_configuration` - no longer require `lifecycle_ignore_changes` for the `value` property when using a key vault reference ([#24702](https://github.com/hashicorp/terraform-provider-azurerm/issues/24702))
* `azurerm_app_service_managed_certificate` - fix casing issue in `app_service_plan_id` by parsing insensitively ([#24664](https://github.com/hashicorp/terraform-provider-azurerm/issues/24664))
* `azurerm_cognitive_deployment` - updates now include the `version` property ([#24700](https://github.com/hashicorp/terraform-provider-azurerm/issues/24700))
* `azurerm_dns_cname_record` - prevent casing issue in `target_resource_id` by parsing the ID insensitively ([#24181](https://github.com/hashicorp/terraform-provider-azurerm/issues/24181))
* `azurerm_mssql_managed_instance_failover_group` - prevent an issue when trying to create a failover group with a managed instance from a different subscription ([#24646](https://github.com/hashicorp/terraform-provider-azurerm/issues/24646))
* `azurerm_storage_account` - conditionally update properties only when needed ([#24669](https://github.com/hashicorp/terraform-provider-azurerm/issues/24669))
* `azurerm_storage_account` - change update order for `access_tier`to prevent errors when uploading blobs to the archive tier ([#22250](https://github.com/hashicorp/terraform-provider-azurerm/issues/22250))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/1075/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>

github-actions · 2024-04-27T02:04:54Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

xiaxyi added 2 commits January 26, 2024 14:17

upgrade servicebus namespace api to 2022-10-01-preview

f754e0e

update

b422c1f

github-actions bot added dependencies service/service-bus size/XL labels Jan 26, 2024

xiaxyi mentioned this pull request Jan 26, 2024

Support for multiple partitions in azurerm_servicebus_namespace #24597

Closed

1 task

tombuildsstuff requested changes Jan 26, 2024

View reviewed changes

github-actions bot added the waiting-response label Jan 26, 2024

update code in state migration

9b3e626

github-actions bot added state-migration size/S and removed waiting-response size/XL labels Jan 26, 2024

tombuildsstuff approved these changes Jan 26, 2024

View reviewed changes

tombuildsstuff added this to the v3.90.0 milestone Jan 26, 2024

tombuildsstuff merged commit d692b82 into hashicorp:main Jan 26, 2024
30 checks passed

tombuildsstuff added a commit that referenced this pull request Jan 26, 2024

updating to include #24650

4b49886

rizkybiz pushed a commit to rizkybiz/terraform-provider-azurerm that referenced this pull request Jan 30, 2024

updating to include hashicorp#24650

f266931

github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_servicebus_namespace` - upgrade api version to `2022-10-01-preview` #24650

`azurerm_servicebus_namespace` - upgrade api version to `2022-10-01-preview` #24650

xiaxyi commented Jan 26, 2024 •

edited

tombuildsstuff left a comment

tombuildsstuff Jan 26, 2024

xiaxyi commented Jan 26, 2024

tombuildsstuff left a comment

github-actions bot commented Apr 27, 2024

azurerm_servicebus_namespace - upgrade api version to 2022-10-01-preview #24650

azurerm_servicebus_namespace - upgrade api version to 2022-10-01-preview #24650

Conversation

xiaxyi commented Jan 26, 2024 • edited

tombuildsstuff left a comment

Choose a reason for hiding this comment

tombuildsstuff Jan 26, 2024

Choose a reason for hiding this comment

xiaxyi commented Jan 26, 2024

tombuildsstuff left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 27, 2024

`azurerm_servicebus_namespace` - upgrade api version to `2022-10-01-preview` #24650

`azurerm_servicebus_namespace` - upgrade api version to `2022-10-01-preview` #24650

xiaxyi commented Jan 26, 2024 •

edited