`azurerm_kusto_cluster` - Support `None pattern` for `virtual_network_configuration` block #24733

liuwuliuyun · 2024-02-01T03:17:52Z

azurerm_kusto_cluster

Split create and update function in this resource.
Support None pattern for virtual_network_configuration block.
None pattern coding guidline
Removing forceNew from virtual_network_configuration block.
Adding new test example.
Fixes 'azurerm_kusto_cluster' resource applies 'virtual_network_configuration' even if it is present in the 'ignore_changes' block #24739
Testing evidence:

GOROOT=C:\Program Files\Go #gosetup
GOPATH=C:\Users\yunliu1\go #gosetup
"C:\Program Files\Go\bin\go.exe" test -c -o C:\Users\yunliu1\AppData\Local\JetBrains\GoLand2023.3\tmp\GoLand\___TestAccKustoCluster_vnet_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/kusto #gosetup
"C:\Program Files\Go\bin\go.exe" tool test2json -t C:\Users\yunliu1\AppData\Local\JetBrains\GoLand2023.3\tmp\GoLand\___TestAccKustoCluster_vnet_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto.test.exe -test.v -test.paniconexit0 -test.run ^\QTestAccKustoCluster_vnet\E$ #gosetup
=== RUN   TestAccKustoCluster_vnet
=== PAUSE TestAccKustoCluster_vnet
=== CONT  TestAccKustoCluster_vnet
--- PASS: TestAccKustoCluster_vnet (2300.45s)
PASS


Process finished with the exit code 0

WodansSon

@liuwuliuyun, this is looking really good so far. I left a few comments which I believe should be addressed. Once that is done this LGTM! 🚀

internal/services/kusto/kusto_cluster_resource.go

WodansSon · 2024-02-07T00:48:14Z

internal/services/kusto/kusto_cluster_resource.go

@@ -145,23 +145,25 @@ func resourceKustoCluster() *pluginsdk.Resource {
 			"virtual_network_configuration": {


Does this block need to be computed optional?

I thought Hashicorp doesn't allow any property marked as computed optional and user has to manually ignore changes for Computed Optional property. Should we added this to the block?

internal/services/kusto/kusto_cluster_resource_test.go

Co-authored-by: Wodans Son <20408400+WodansSon@users.noreply.github.com>

# Conflicts: # internal/services/kusto/kusto_cluster_resource.go

website/docs/r/kusto_cluster.html.markdown

liuwuliuyun · 2024-03-11T03:28:12Z

Pending for a re-review from parter team

katbyte

LGTM 🌵

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/azurerm" updated from "3.95.0" to "3.96.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.96.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.96.0
ENHANCEMENTS:

* dependencies: updating to `v0.20240314.1083835` of `github.com/hashicorp/go-azure-sdk` ([#25255](https://github.com/hashicorp/terraform-provider-azurerm/issues/25255))
* dependencies: updating to `v0.25.1` of `github.com/tombuildsstuff/giovanni` ([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))
* dependencies: updating to `v1.33.0` of `google.golang.org/protobuf` ([#25243](https://github.com/hashicorp/terraform-provider-azurerm/issues/25243))
* `storage`: updating the data plane resources to use the transport layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))
* Data Source: `azurerm_storage_table_entities` - support for AAD authentication ([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))
* Data Source: `azurerm_storage_table_entity` - support for AAD authentication ([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))
* `azurerm_kusto_cluster` - support `None` pattern for the `virtual_network_configuration` block ([#24733](https://github.com/hashicorp/terraform-provider-azurerm/issues/24733))
* `azurerm_linux_function_app` - support for the Node `20` runtime ([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))
* `azurerm_linux_function_app_slot` - support for the Node `20` runtime ([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))
* `azurerm_stack_hci_cluster` - support the `identity`, `cloud_id`, `service_endpoint` and `resource_provider_object_id` properties [GH-25031]
* `azurerm_storage_share_file` - support for AAD authentication ([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))
* `azurerm_storage_share_directory` - support for AAD authentication, deprecate `share_name` and `storage_account_name` in favor of `storage_share_id` ([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))
* `azurerm_storage_table_entity` - support for AAD authentication, deprecate `share_name` and `storage_account_name` in favor of `storage_table_id` ([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))
* `azurerm_storage_table_entity` - support for AAD authentication ([#24798](https://github.com/hashicorp/terraform-provider-azurerm/issues/24798))
* `azurerm_windows_function_app` - support for the Node `20` runtime ([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))
* `azurerm_windows_function_app_slot` - support for the Node `20` runtime ([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))
* `azurerm_windows_web_app` - support for the Node `20` runtime ([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))
* `azurerm_windows_web_app_slot` - support for the Node `20` runtime ([#24073](https://github.com/hashicorp/terraform-provider-azurerm/issues/24073))

BUG FIXES:

* `azurerm_container_app_custom_domain` - fix resource ID parsing bug preventing import ([#25192](https://github.com/hashicorp/terraform-provider-azurerm/issues/25192))
* `azurerm_windows_web_app` - fix incorrect warning message when checking name availability ([#25214](https://github.com/hashicorp/terraform-provider-azurerm/issues/25214))
* `azurerm_virtual_machine_run_command` - prevent a bug during updates ([#25186](https://github.com/hashicorp/terraform-provider-azurerm/issues/25186))
* Data Source: `azurerm_storage_table_entities` - Fix `items.x.properties` truncating to one entry ([#25211](https://github.com/hashicorp/terraform-provider-azurerm/issues/25211))</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/52/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>

github-actions · 2024-04-27T02:04:09Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

liuwuliuyun added 2 commits January 31, 2024 17:29

split create/update and update vnet block

8cd2cfa

split create/update and update vnet block

6baa1da

github-actions bot added documentation service/kusto size/XL labels Feb 1, 2024

update testcase for tc test

c20e29f

liuwuliuyun changed the title ~~azurerm_kusto_cluster - Support None pattern for virtual_network_configuration block.~~ azurerm_kusto_cluster - Support None pattern for virtual_network_configuration block Feb 2, 2024

WodansSon requested changes Feb 7, 2024

View reviewed changes

github-actions bot added the waiting-response label Feb 7, 2024

Update internal/services/kusto/kusto_cluster_resource.go

a43ad56

Co-authored-by: Wodans Son <20408400+WodansSon@users.noreply.github.com>

github-actions bot removed the waiting-response label Feb 8, 2024

liuwuliuyun and others added 3 commits February 8, 2024 09:35

Update internal/services/kusto/kusto_cluster_resource.go

b559de4

Co-authored-by: Wodans Son <20408400+WodansSon@users.noreply.github.com>

Update internal/services/kusto/kusto_cluster_resource.go

ae21fee

Co-authored-by: Wodans Son <20408400+WodansSon@users.noreply.github.com>

Update internal/services/kusto/kusto_cluster_resource_test.go

b6a091d

Co-authored-by: Wodans Son <20408400+WodansSon@users.noreply.github.com>

liuwuliuyun requested a review from WodansSon February 9, 2024 02:27

liuwuliuyun added 2 commits February 20, 2024 10:38

Merge branch 'main' into kusto-rmfn

ad12126

# Conflicts: # internal/services/kusto/kusto_cluster_resource.go

split update and create function

b269376

WodansSon marked this pull request as ready for review February 26, 2024 19:32

katbyte requested changes Feb 29, 2024

View reviewed changes

website/docs/r/kusto_cluster.html.markdown Show resolved Hide resolved

github-actions bot added the waiting-response label Feb 29, 2024

liuwuliuyun requested a review from katbyte March 6, 2024 00:54

github-actions bot removed the waiting-response label Mar 11, 2024

katbyte approved these changes Mar 12, 2024

View reviewed changes

katbyte merged commit ee9c84f into hashicorp:main Mar 12, 2024
36 checks passed

github-actions bot added this to the v3.96.0 milestone Mar 12, 2024

katbyte added a commit that referenced this pull request Mar 12, 2024

Update CHANGELOG.md #24733

922f2ea

liuwuliuyun deleted the kusto-rmfn branch March 27, 2024 08:45

github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_kusto_cluster` - Support `None pattern` for `virtual_network_configuration` block #24733

`azurerm_kusto_cluster` - Support `None pattern` for `virtual_network_configuration` block #24733

liuwuliuyun commented Feb 1, 2024 •

edited

Loading

WodansSon left a comment

WodansSon Feb 7, 2024

liuwuliuyun Feb 8, 2024

liuwuliuyun commented Mar 11, 2024

katbyte left a comment

github-actions bot commented Apr 27, 2024

		@@ -145,23 +145,25 @@ func resourceKustoCluster() *pluginsdk.Resource {
		"virtual_network_configuration": {

azurerm_kusto_cluster - Support None pattern for virtual_network_configuration block #24733

azurerm_kusto_cluster - Support None pattern for virtual_network_configuration block #24733

Conversation

liuwuliuyun commented Feb 1, 2024 • edited Loading

WodansSon left a comment

Choose a reason for hiding this comment

WodansSon Feb 7, 2024

Choose a reason for hiding this comment

liuwuliuyun Feb 8, 2024

Choose a reason for hiding this comment

liuwuliuyun commented Mar 11, 2024

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 27, 2024

`azurerm_kusto_cluster` - Support `None pattern` for `virtual_network_configuration` block #24733

`azurerm_kusto_cluster` - Support `None pattern` for `virtual_network_configuration` block #24733

liuwuliuyun commented Feb 1, 2024 •

edited

Loading