New Resource: `azurerm_dev_center_catalog` #24833

jiaweitao001 · 2024-02-09T06:47:07Z

Add support for new resource azurerm_dev_center_catalog.
All tests are passing.

--- PASS: TestAccDevCenterCatalogs_basic (455.75s)
--- PASS: TestAccDevCenterCatalogs_adoGit (504.90s)
--- PASS: TestAccDevCenterCatalogs_update (537.58s)
PASS

katbyte · 2024-02-09T15:37:55Z

website/docs/r/dev_center_catalogs.html.markdown

+
+* `path` - (Required) The folder where the catalog items can be found inside the repository.
+
+* `secret_identifier` - (Required) A reference to the Key Vault secret containing a security token to authenticate to a Git repository.


if this is a key vault key should it be

Suggested change

* `secret_identifier` - (Required) A reference to the Key Vault secret containing a security token to authenticate to a Git repository.

* `key_vault_key_url|id` - (Required) A reference to the Key Vault secret containing a security token to authenticate to a Git repository.

tombuildsstuff · 2024-02-13T15:39:33Z

internal/services/devcenter/dev_center_catalogs_resource.go

+				"gitHub",
+				"adoGit",


Based on the design of this resource these want to be two blocks which conflict with each other, one for github and one for azure_devops_git - or two entirely separate resources - rather than trying to top-level these fields, can we update this to use two blocks instead?

Split to 2 separate blocks as requested.

katbyte

LGTM 🪴

* New Resource: azurerm_dev_center_catalog * fix timeout * fix naming * split github/adogit blocks * remove nil check

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/azurerm" updated from "3.92.0" to "3.93.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.93.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.93.0
* **New Data Source**: `azurerm_express_route_circuit_peering` ([#24971](https://github.com/hashicorp/terraform-provider-azurerm/issues/24971))
* **New Data Source**: `azurerm_storage_table_entities` ([#24973](https://github.com/hashicorp/terraform-provider-azurerm/issues/24973))
* **New Resource**: `azurerm_dev_center_catalog` ([#24833](https://github.com/hashicorp/terraform-provider-azurerm/issues/24833))
* **New Resource**: `azurerm_system_center_virtual_machine_manager_server` ([#24278](https://github.com/hashicorp/terraform-provider-azurerm/issues/24278))

BUG FIXES:

* `azurerm_key_vault` - conditionally polling the Data Plane endpoint when `public_network_access_enabled` is set to false ([#23823](https://github.com/hashicorp/terraform-provider-azurerm/issues/23823))
* `azurerm_storage_account` - allow the `identity.type` property to be `SystemAssigned, UserAssigned` when using a Customer Managed Key ([#24923](https://github.com/hashicorp/terraform-provider-azurerm/issues/24923))
* `azurerm_automation_account` - prevent the `identity.identity_ids` User Assigned identity being set when not specified in config ([#24977](https://github.com/hashicorp/terraform-provider-azurerm/issues/24977))

ENHANCEMENTS:

* dependencies: updating to `v0.20240221.1170458` of `hashicorp/go-azure-sdk` ([#24967](https://github.com/hashicorp/terraform-provider-azurerm/issues/24967))
* dependencies: refactor `azurerm_spring_cloud_configuration_service` to use `go-azure-sdk` ([#24918](https://github.com/hashicorp/terraform-provider-azurerm/issues/24918))
* provider: support or the feature flag `virtual_machine_scale_set.reimage_on_manual_upgrade` ([#22975](https://github.com/hashicorp/terraform-provider-azurerm/issues/22975))
* `sentinel`: updating to use the transport layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#24962](https://github.com/hashicorp/terraform-provider-azurerm/issues/24962))
* `sqlvirtualmachines`: updating to use the transport layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#24912](https://github.com/hashicorp/terraform-provider-azurerm/issues/24912))
* `nginx` : updating to use `2024-01-01-preview` ([#24868](https://github.com/hashicorp/terraform-provider-azurerm/issues/24868))
* `azurerm_cosmosdb_account` - support for the `backup.tier` property ([#24595](https://github.com/hashicorp/terraform-provider-azurerm/issues/24595))
* `azurerm_linux_virtual_machine` - the `virtual_machine_scale_set_id` proeprty can now be changed without creating a new resource ([#24768](https://github.com/hashicorp/terraform-provider-azurerm/issues/24768))
* `azurerm_machine_learning_workspace` - support for the `managed_network.isolation_mode` property ([#24951](https://github.com/hashicorp/terraform-provider-azurerm/issues/24951))
* `azurerm_private_dns_resolver_inbound_endpoint` - support the `static` value for the `private_ip_allocation_method` property ([#24952](https://github.com/hashicorp/terraform-provider-azurerm/issues/24952))
* `azurerm_postgresql_flexible_server` - expose the `storage_tier` field ([#24892](https://github.com/hashicorp/terraform-provider-azurerm/issues/24892))
* `azurerm_redis_cache` - support for the `preferred_data_persistence_auth_method` property ([#24370](https://github.com/hashicorp/terraform-provider-azurerm/issues/24370))
* `azurerm_servicebus_namespace` - support for the `premium_messaging_partitions` property ([#24676](https://github.com/hashicorp/terraform-provider-azurerm/issues/24676))
* `azurerm_windows_virtual_machine` - the `virtual_machine_scale_set_id` proeprty can now be changed without creating a new resource ([#24768](https://github.com/hashicorp/terraform-provider-azurerm/issues/24768))

BUG FIXES:

* `azurerm_cognitive_deployment` - the `version_upgrade_option` property can not be updated without creating a new resource ([#24922](https://github.com/hashicorp/terraform-provider-azurerm/issues/24922))
* `azurerm_data_protection_backup_vault` - support or the `soft_delete` and `retention_duration_in_days` properties ([#24775](https://github.com/hashicorp/terraform-provider-azurerm/issues/24775))
* `azurerm_data_factory_pipeline` - correctly handle incorrect header values ([#24921](https://github.com/hashicorp/terraform-provider-azurerm/issues/24921))
* `azurerm_kusto_cluster` - `optimized_auto_scale` is now updated after `sku` has been updated ([#24906](https://github.com/hashicorp/terraform-provider-azurerm/issues/24906))
* `azurerm_key_vault_certificate` - will now only update the `lifetime_action` of the certificate block unless otherwise required ([#24755](https://github.com/hashicorp/terraform-provider-azurerm/issues/24755))
* `azurerm_linux_virtual_machine_scale_set` - correctly include `public_ip_prefix_id` during updates ([#24939](https://github.com/hashicorp/terraform-provider-azurerm/issues/24939))
* `azurerm_postgresql_flexible_server` - the `customer_managed_key.key_vault_key_id` property is now required ([#24981](https://github.com/hashicorp/terraform-provider-azurerm/issues/24981))
* `azurerm_nginx_deployment` - changing the `sku` property now creates a new resource ([#24905](https://github.com/hashicorp/terraform-provider-azurerm/issues/24905))
* `azurerm_orchestrated_virtual_machine_scale_set` - the `disk_size_gb` and `lun` parameters of `data_disks` are optional now ([#24944](https://github.com/hashicorp/terraform-provider-azurerm/issues/24944))
* `azurerm_storage_account` - change order of API calls to be GET-then-PUT ratehr then PATCHES ([#23935](https://github.com/hashicorp/terraform-provider-azurerm/issues/23935))
* `azurerm_storage_account` - improve the validation around the `immutability_policy` being used with `blob_properties` ([#24938](https://github.com/hashicorp/terraform-provider-azurerm/issues/24938))
* `azurerm_security_center_setting` - prevent a bug when name is `SENTINEL` ([#24497](https://github.com/hashicorp/terraform-provider-azurerm/issues/24497))
* `azurerm_windows_virtual_machine_scale_set` - correctly include `public_ip_prefix_id` during updates ([#24939](https://github.com/hashicorp/terraform-provider-azurerm/issues/24939))




</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/19/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>

* New Resource: azurerm_dev_center_catalog * fix timeout * fix naming * split github/adogit blocks * remove nil check

github-actions · 2024-04-22T02:09:57Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

New Resource: azurerm_dev_center_catalog

0df5465

github-actions bot added documentation service/dev-center size/XL waiting-response labels Feb 9, 2024

fix timeout

3e6ebc5

github-actions bot removed the waiting-response label Feb 9, 2024

katbyte reviewed Feb 9, 2024

View reviewed changes

github-actions bot added the waiting-response label Feb 9, 2024

fix naming

6a4f792

github-actions bot removed the waiting-response label Feb 12, 2024

tombuildsstuff reviewed Feb 13, 2024

View reviewed changes

tombuildsstuff added the waiting-response label Feb 13, 2024

split github/adogit blocks

627052d

github-actions bot added waiting-response and removed waiting-response labels Feb 18, 2024

remove nil check

2ca8951

github-actions bot removed the waiting-response label Feb 18, 2024

jiaweitao001 requested a review from tombuildsstuff February 18, 2024 08:01

katbyte approved these changes Feb 20, 2024

View reviewed changes

katbyte merged commit f5203d4 into hashicorp:main Feb 20, 2024
34 checks passed

github-actions bot added this to the v3.93.0 milestone Feb 20, 2024

katbyte added a commit that referenced this pull request Feb 20, 2024

Update CHANGELOG.md #24833

02c0e98

rizkybiz pushed a commit to rizkybiz/terraform-provider-azurerm that referenced this pull request Feb 21, 2024

Update CHANGELOG.md hashicorp#24833

3289b87

rizkybiz pushed a commit to rizkybiz/terraform-provider-azurerm that referenced this pull request Feb 29, 2024

Update CHANGELOG.md hashicorp#24833

f259080

github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_dev_center_catalog` #24833

New Resource: `azurerm_dev_center_catalog` #24833

jiaweitao001 commented Feb 9, 2024 •

edited

Loading

katbyte Feb 9, 2024

tombuildsstuff Feb 13, 2024

jiaweitao001 Feb 18, 2024

katbyte left a comment

github-actions bot commented Apr 22, 2024


		* `path` - (Required) The folder where the catalog items can be found inside the repository.

		* `secret_identifier` - (Required) A reference to the Key Vault secret containing a security token to authenticate to a Git repository.

	* `secret_identifier` - (Required) A reference to the Key Vault secret containing a security token to authenticate to a Git repository.
	* `key_vault_key_url\|id` - (Required) A reference to the Key Vault secret containing a security token to authenticate to a Git repository.

New Resource: azurerm_dev_center_catalog #24833

New Resource: azurerm_dev_center_catalog #24833

Conversation

jiaweitao001 commented Feb 9, 2024 • edited Loading

katbyte Feb 9, 2024

Choose a reason for hiding this comment

tombuildsstuff Feb 13, 2024

Choose a reason for hiding this comment

jiaweitao001 Feb 18, 2024

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 22, 2024

New Resource: `azurerm_dev_center_catalog` #24833

New Resource: `azurerm_dev_center_catalog` #24833

jiaweitao001 commented Feb 9, 2024 •

edited

Loading