#24898: azurerm_linux_virtual_machine_scale_set and azurerm_windows_virtual_machine_scale_set - support max_surge_instances for vmss rolling upgrades

[harshavmb]

Support max_surge_instances for azurerm_linux_virtual_machine_scale_set and azurerm_windows_virtual_machine_scale_set rolling upgrades.

Fixes #24898.

[github-actions]

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

[stephybun]

Any updates on this @harshavmb, or could we close this until you're ready to come back to this?

[harshavmb]

Hi @stephybun ,

I did give a pause on this PR as I felt max_surge is still a preview feature. I shall check the docs once again & rework on this.

[stephybun]

@harshavmb if this is still in preview would you mind closing this PR. It can always be re-opened once it's gone GA and ready for review.

[harshavmb]

Hi @stephybun ,

I did have another look on this. However, it's failing with below error when I run acceptance tests locally.

The subscription is not registered for Microsoft.Compute/MaxSurgeRollingUpgrade. Please enable this feature on the subscription.

RestAPI specs here, don't say this as a preview feature.

I could enable this feature at subscription level & I know this would work but don't think the acceptance tests run at your end will allow such tests.

Please have a say on this..

[stephybun]

@harshavmb I've registered the feature on our test subs. If this is ready can you please move this PR out of draft?

[harshavmb]

@stephybun / @katbyte ,

Over to you for review..

[katbyte]

Thanks @harshavmb - LGTM 🚂