Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_container_app_custom_domain - fix when azurerm_container_app has secret specified (#25196) #25251

Merged

Conversation

AButler
Copy link
Contributor

@AButler AButler commented Mar 14, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.

Documentation Changes

  • Documentation is written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.

Description

Secrets were not being resolved when updating the container app.

Testing Logs/Evidence

Related Issue(s)

Fixes #25196.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@mbfrahry mbfrahry changed the title azurerm_container_app_custom_domain - fix when container app has secrets (#25196) azurerm_container_app_custom_domain - fix when azurerm_container_app has secret specified (#25196) Mar 19, 2024
mbfrahry

This comment was marked as outdated.

@mbfrahry mbfrahry added this to the v3.97.0 milestone Mar 19, 2024
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AButler, apologies for the premature approval. Looks like this will need some fixes to get around linting

@AButler
Copy link
Contributor Author

AButler commented Mar 20, 2024

@mbfrahry Sorry about that - was missing some imports. Have pushed the changes.

@AButler
Copy link
Contributor Author

AButler commented Mar 21, 2024

@mbfrahry I'm unsure why this one check is failing as it appears to be unrelated to the changes I made

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AButler - LGTM 🚒

@katbyte katbyte merged commit c6ad3a7 into hashicorp:main Mar 21, 2024
29 of 30 checks passed
katbyte added a commit that referenced this pull request Mar 21, 2024
@AButler AButler deleted the fix-container-app-custom-domain-secrets branch March 22, 2024 07:56
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_container_app_custom_domain errors if container app has private registry (secret set)
3 participants