Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netapp_account_resource add missing Active Directory properties #25340

Merged
merged 15 commits into from
Mar 21, 2024

Conversation

bruceharrison1984
Copy link
Contributor

@bruceharrison1984 bruceharrison1984 commented Mar 20, 2024

Description

This PR adds some properties to netapp_account_resource that were missing from the Active Directory configuration block. This is the first half of a PR that will enable Kerberos NetApp Volumes.

  • ad_name: This property is required to enable Kerberos functionality
  • kdc_ip: This property is required to enable Kerberos functionality
  • site_name: This property is required in the Azure Portal, but was absent from the provider
    • It will default to Default-First-Site-Name if left blank, which is what the Azure API was doing behind the scenes already.
  • enable_aes_encryption
  • allow_local_nfs_users_with_ldap
  • server_root_ca_certificate
  • enable_ldap_over_tls
  • enable_ldap_signing
  • Improve test to check for values

Our customer only needed support for Kerberos, but we added a couple more easy wins while we were here. There are still additional properties missing, but this PR adds the easiest ones.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • netapp_account_resource - support for the ad_name property
  • netapp_account_resource - support for the kdc_ip property
  • netapp_account_resource - support for the site_name property [Support for Azure Netapp Files - AD Site Name #12462]
  • netapp_account_resource - support for the enable_aes_encryption property
  • netapp_account_resource - support for the allow_local_nfs_users_with_ldap property
  • netapp_account_resource - support for the server_root_ca_certificate property
  • netapp_account_resource - support for the enable_ldap_over_tls property
  • netapp_account_resource - support for the enable_ldap_signing property
  • netapp_account_resource - relax smb_server_name regex [azurerm_netapp_account SMB server name check is too restrictive #11674]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

@bruceharrison1984 bruceharrison1984 changed the title add missing ad properties netapp_account_resource add missing ad properties Mar 20, 2024
@bruceharrison1984 bruceharrison1984 changed the title netapp_account_resource add missing ad properties netapp_account_resource add missing Active Directory properties Mar 20, 2024
@bruceharrison1984 bruceharrison1984 marked this pull request as ready for review March 21, 2024 04:03
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bruceharrison1984 - couple comments left inline

internal/services/netapp/netapp_account_resource.go Outdated Show resolved Hide resolved
internal/services/netapp/netapp_account_resource.go Outdated Show resolved Hide resolved
internal/services/netapp/netapp_account_resource.go Outdated Show resolved Hide resolved
internal/services/netapp/netapp_account_resource.go Outdated Show resolved Hide resolved
internal/services/netapp/netapp_account_resource.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bruceharrison1984 - couple comments left inline

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧲

@katbyte katbyte merged commit 5a6226e into hashicorp:main Mar 21, 2024
33 checks passed
@github-actions github-actions bot added this to the v3.97.0 milestone Mar 21, 2024
@bruceharrison1984 bruceharrison1984 deleted the netapp-account-ad branch March 21, 2024 20:44
katbyte added a commit that referenced this pull request Mar 21, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants