Add azurerm_application_insights_api_key resource #2556

pdecat · 2018-12-20T16:21:06Z

Resolves #2547

TODO:

add documentation
add changelog

pdecat · 2018-12-20T16:25:15Z

Acceptance test results:

# make testacc TEST=./azurerm TESTARGS='-run=TestAccAzureRMApplicationInsightsAPIKey_.* -count=1'                                                        
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -run=TestAccAzureRMApplicationInsightsAPIKey_.* -count=1 -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_no_permission
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_no_permission
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_requiresImport
--- SKIP: TestAccAzureRMApplicationInsightsAPIKey_requiresImport (0.00s)
    resource_arm_application_insights_api_key_test.go:33: Skipping since resources aren't required to be imported                                         
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission                                                                            
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission                                                                            
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_full_permissions
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_full_permissions
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_no_permission
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission                                                                            
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_no_permission (58.52s)
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_full_permissions
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions (92.84s)
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission (138.72s)
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission (138.93s)
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_full_permissions (90.52s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       149.063s

tombuildsstuff

hey @pdecat

Thanks for this PR :)

I've taken a look through and left some comments inline about the design of the resources schema, but this is otherwise off to a good start 👍

Thanks!

azurerm/resource_arm_application_insights_api_key.go

azurerm/helpers/azure/app_insights.go

azurerm/resource_arm_application_insights_api_key.go

azurerm/helpers/azure/app_insights.go

Co-Authored-By: pdecat <pdecat@gmail.com>

…by `application_insights_id` on `azurerm_application_insights_api_key` resource

Co-Authored-By: pdecat <pdecat@gmail.com>

pdecat · 2018-12-21T11:55:44Z

Updated acceptance test results:

# make testacc TEST=./azurerm TESTARGS='-run=TestAccAzureRMApplicationInsightsAPIKey_.* -count=1'                                                        
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -run=TestAccAzureRMApplicationInsightsAPIKey_.* -count=1 -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_no_permission
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_no_permission
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_requiresImport
--- SKIP: TestAccAzureRMApplicationInsightsAPIKey_requiresImport (0.00s)
    resource_arm_application_insights_api_key_test.go:33: Skipping since resources aren't required to be imported                                         
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission                                                                            
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission                                                                            
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_full_permissions
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_full_permissions
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_no_permission
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission                                                                            
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_full_permissions
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_no_permission (60.60s)
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission (73.83s)
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_full_permissions (73.89s)
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission (75.60s)
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions (73.05s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       133.687s

I'll proceed to documentation updates now that the end-user exposed schema should no longer change.

katbyte

@pdecat,

This is looking in good shape. I've let a couple comments inline and once they are addressed this should be good to merge 🙂

CHANGELOG.md

azurerm/helpers/azure/app_insights.go

azurerm/resource_arm_application_insights_api_key.go

website/docs/r/application_insights_api_key.html.markdown

azurerm/resource_arm_application_insights_api_key_test.go

Co-Authored-By: pdecat <pdecat@gmail.com>

… field

…insights_id field

pdecat · 2018-12-27T13:21:18Z

Current acceptance test results:

# make testacc TEST=./azurerm TESTARGS='-run=TestAccAzureRMApplicationInsightsAPIKey_.* -count=1'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -run=TestAccAzureRMApplicationInsightsAPIKey_.* -count=1 -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_no_permission
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_no_permission
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_requiresImport
--- SKIP: TestAccAzureRMApplicationInsightsAPIKey_requiresImport (0.00s)
    resource_arm_application_insights_api_key_test.go:33: Skipping since resources aren't required to be imported
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission
=== RUN   TestAccAzureRMApplicationInsightsAPIKey_full_permissions
=== PAUSE TestAccAzureRMApplicationInsightsAPIKey_full_permissions
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_no_permission
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_full_permissions
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission
=== CONT  TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_no_permission (61.67s)
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_authenticate_permission (74.94s)
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_full_permissions (74.99s)
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_read_telemetry_permissions (75.10s)
--- PASS: TestAccAzureRMApplicationInsightsAPIKey_write_annotations_permission (77.97s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm       78.001s

katbyte

Thank you for the updates @pdecat, LGTM now 👍

azurerm/resource_arm_application_insights_api_key.go

ghost · 2019-03-05T14:16:05Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

ghost added the size/XL label Dec 20, 2018

Add azurerm_application_insights_api_key resource

47d9a22

pdecat force-pushed the f-azurerm_application_insights_api_key branch from 751c2c7 to 47d9a22 Compare December 20, 2018 16:22

pdecat mentioned this pull request Dec 20, 2018

Implement Application Insights API Key management #2547

Closed

tombuildsstuff reviewed Dec 20, 2018

View reviewed changes

tombuildsstuff added enhancement waiting-response service/application-insights labels Dec 20, 2018

tombuildsstuff and others added 2 commits December 21, 2018 08:25

Return nil instead of err

acda774

Co-Authored-By: pdecat <pdecat@gmail.com>

Error check setting complex objects in state

ba3452a

Co-Authored-By: pdecat <pdecat@gmail.com>

pdecat force-pushed the f-azurerm_application_insights_api_key branch from 7daf67d to ba3452a Compare December 21, 2018 11:18

pdecat added 3 commits December 21, 2018 12:27

Replace resource_group_name and application_insights_name fields …

2c4d544

…by `application_insights_id` on `azurerm_application_insights_api_key` resource

Remove superfluous status code check

d6a6134

Use utils.ResponseWasNotFound helper to check API response status code

4b1c309

pdecat force-pushed the f-azurerm_application_insights_api_key branch 2 times, most recently from cab7e78 to 0755c3c Compare December 21, 2018 11:52

Enforce read & write permissions values

9e73208

Co-Authored-By: pdecat <pdecat@gmail.com>

pdecat force-pushed the f-azurerm_application_insights_api_key branch from 0755c3c to 9e73208 Compare December 21, 2018 11:52

ghost removed the waiting-response label Dec 21, 2018

Fix err declaration shadowing reported by vetshadow linter

f5d343e

pdecat force-pushed the f-azurerm_application_insights_api_key branch from 6f0a16e to f5d343e Compare December 21, 2018 15:58

ghost added the documentation label Dec 21, 2018

katbyte requested changes Dec 24, 2018

View reviewed changes

katbyte added the waiting-response label Dec 24, 2018

pdecat added 4 commits December 27, 2018 13:39

Add documentation

f017364

Fix api keys names in documentation example

a24e687

Fix api keys outputs in documentation example

4e3b1a1

Fix api keys outputs in documentation example

7a5dee4

Update website/docs/r/application_insights_api_key.html.markdown

3ad1559

Co-Authored-By: pdecat <pdecat@gmail.com>

pdecat force-pushed the f-azurerm_application_insights_api_key branch from 35d715d to 3ad1559 Compare December 27, 2018 12:39

Let expander & flattener functions return empty array instead of nil

ec8ad78

pdecat force-pushed the f-azurerm_application_insights_api_key branch from a1a8f5a to ec8ad78 Compare December 27, 2018 12:45

pdecat added 3 commits December 27, 2018 13:53

Add minimal validation to azurerm_application_insights_api_key's name…

d42ad5b

… field

Move api_key computed value at the bottom of schema

1b0a4d8

Add validation to azurerm_application_insights_api_key's application_…

b46ed17

…insights_id field

ghost removed the waiting-response label Dec 27, 2018

katbyte approved these changes Dec 28, 2018

View reviewed changes

azurerm/resource_arm_application_insights_api_key.go Show resolved Hide resolved

katbyte merged commit 44fb9c4 into hashicorp:master Dec 28, 2018

katbyte added a commit that referenced this pull request Dec 28, 2018

Update CHANGELOG.md to include #2556

457e700

pdecat deleted the f-azurerm_application_insights_api_key branch December 28, 2018 09:09

tombuildsstuff added this to the 1.21.0 milestone Dec 28, 2018

hashicorp locked and limited conversation to collaborators Mar 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add azurerm_application_insights_api_key resource #2556

Add azurerm_application_insights_api_key resource #2556

pdecat commented Dec 20, 2018 •

edited

pdecat commented Dec 20, 2018

tombuildsstuff left a comment

pdecat commented Dec 21, 2018

katbyte left a comment

pdecat commented Dec 27, 2018

katbyte left a comment

ghost commented Mar 5, 2019

Add azurerm_application_insights_api_key resource #2556

Add azurerm_application_insights_api_key resource #2556

Conversation

pdecat commented Dec 20, 2018 • edited

pdecat commented Dec 20, 2018

tombuildsstuff left a comment

Choose a reason for hiding this comment

pdecat commented Dec 21, 2018

katbyte left a comment

Choose a reason for hiding this comment

pdecat commented Dec 27, 2018

katbyte left a comment

Choose a reason for hiding this comment

ghost commented Mar 5, 2019

pdecat commented Dec 20, 2018 •

edited