Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_bastion_host - adding property kerberos_enabled #25823

Merged
merged 5 commits into from May 6, 2024

Conversation

oWretch
Copy link
Contributor

@oWretch oWretch commented May 1, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

Add the kerberos_enabled property to azurerm_bastion_host.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
TF_ACC=1 go test -v ./internal/services/network -run="TestAccBastionHost_standardSku" -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccBastionHost_standardSku
=== PAUSE TestAccBastionHost_standardSku
=== CONT  TestAccBastionHost_standardSku
--- PASS: TestAccBastionHost_standardSku (1374.27s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/network       1377.224s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #23670

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oWretch LGTM oncer conflict is resolved 🌻

@github-actions github-actions bot added size/S and removed size/XS labels May 6, 2024
@katbyte katbyte merged commit dae19d5 into hashicorp:main May 6, 2024
32 checks passed
@github-actions github-actions bot added this to the v3.103.0 milestone May 6, 2024
katbyte added a commit that referenced this pull request May 6, 2024
@oWretch oWretch deleted the f/bastion-kerberos branch May 8, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing property "Enable Kerberos" in azurerm_bastion_host
2 participants