Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for PowerShell 7.4 #25980

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

Chambras
Copy link
Contributor

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

Adding support for PowerShell 7.4 for both Linux and Windows Functions App.
Updated documentation with new version support.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Windows test log:

$ make acctests SERVICE='appservice' TESTARGS=' -run=TestAccWindowsFunctionApp_appStackPowerShellCore74' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/appservice -run=TestAccWindowsFunctionApp_appStackPowerShellCore74 -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccWindowsFunctionApp_appStackPowerShellCore74
=== PAUSE TestAccWindowsFunctionApp_appStackPowerShellCore74
=== CONT  TestAccWindowsFunctionApp_appStackPowerShellCore74
--- PASS: TestAccWindowsFunctionApp_appStackPowerShellCore74 (150.72s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice    (cached)

Linux test log:

$ make acctests SERVICE='appservice' TESTARGS=' -run=TestAccLinuxFunctionApp_appStackPowerShellCore74' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/appservice -run=TestAccLinuxFunctionApp_appStackPowerShellCore74 -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccLinuxFunctionApp_appStackPowerShellCore74
=== PAUSE TestAccLinuxFunctionApp_appStackPowerShellCore74
=== CONT  TestAccLinuxFunctionApp_appStackPowerShellCore74
--- PASS: TestAccLinuxFunctionApp_appStackPowerShellCore74 (159.06s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice    (cached)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_windows_function_app - support for the PowerShell 7.4
  • azurerm_linux_function_app - support for the PowerShell 7.4

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #25924

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@favoretti
Copy link
Collaborator

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏖️

@katbyte katbyte merged commit 4296848 into hashicorp:main May 15, 2024
32 checks passed
@github-actions github-actions bot added this to the v3.104.0 milestone May 15, 2024
katbyte added a commit that referenced this pull request May 15, 2024
@Chambras Chambras deleted the PSVersionUpdate branch May 15, 2024 18:18
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request May 20, 2024
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>changes detected:&#xA;&#x9;&#34;hashicorp/azurerm&#34; updated from
&#34;3.103.1&#34; to &#34;3.104.0&#34; in file
&#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.104.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.104.0&#xA;FEATURES:&#xA;&#xA;*
New Data Source: `azurerm_elastic_san`
([#25719](https://github.com/hashicorp/terraform-provider-azurerm/issues/25719))&#xA;&#xA;ENHANCEMENTS:&#xA;&#xA;*
New Resource - `azurerm_key_vault_managed_hardware_security_module_key`
([#25935](https://github.com/hashicorp/terraform-provider-azurerm/issues/25935))&#xA;*
Data Source - `azurerm_kubernetes_service_version` - support for the
`default_version` property
([#25953](https://github.com/hashicorp/terraform-provider-azurerm/issues/25953))&#xA;*
`network/applicationgateways` - update to use `hashicorp/go-azure-sdk`
([#25844](https://github.com/hashicorp/terraform-provider-azurerm/issues/25844))&#xA;*
`dataprotection` - update API version to `2024-04-01`
([#25882](https://github.com/hashicorp/terraform-provider-azurerm/issues/25882))&#xA;*
`databasemigration` - update API version to `2021-06-30`
([#25997](https://github.com/hashicorp/terraform-provider-azurerm/issues/25997))&#xA;*
`network/ips` - update to use `hashicorp/go-azure-sdk`
([#25905](https://github.com/hashicorp/terraform-provider-azurerm/issues/25905))&#xA;*
`network/localnetworkgateway` - update to use `hashicorp/go-azure-sdk`
([#25905](https://github.com/hashicorp/terraform-provider-azurerm/issues/25905))&#xA;*
`network/natgateway` - update to use `hashicorp/go-azure-sdk`
([#25905](https://github.com/hashicorp/terraform-provider-azurerm/issues/25905))&#xA;*
`network/networksecuritygroup` - update to use `hashicorp/go-azure-sdk`
([#25971](https://github.com/hashicorp/terraform-provider-azurerm/issues/25971))&#xA;*
`network/publicips` - update to use `hashicorp/go-azure-sdk`
([#25971](https://github.com/hashicorp/terraform-provider-azurerm/issues/25971))&#xA;*
`network/virtualwan` - update to use `hashicorp/go-azure-sdk`
([#25971](https://github.com/hashicorp/terraform-provider-azurerm/issues/25971))&#xA;*
`network/vpn` - update to use `hashicorp/go-azure-sdk`
([#25971](https://github.com/hashicorp/terraform-provider-azurerm/issues/25971))&#xA;*
`azurerm_databricks_workspace` - support for the
`default_storage_firewall_enabled` property
([#25919](https://github.com/hashicorp/terraform-provider-azurerm/issues/25919))&#xA;*
`azurerm_key_vault` - allow previously existing key vaults to continue
to manage the `contact` field prior to the `v3.93.0` conditional polling
change
([#25777](https://github.com/hashicorp/terraform-provider-azurerm/issues/25777))&#xA;*
`azurerm_linux_function_app` - support for the PowerShell `7.4`
([#25980](https://github.com/hashicorp/terraform-provider-azurerm/issues/25980))&#xA;*
`azurerm_log_analytics_cluster` - support for the value `UserAssigned`
in the `identity.type` property
([#25940](https://github.com/hashicorp/terraform-provider-azurerm/issues/25940))&#xA;*
`azurerm_pim_active_role_assignment` - remove hard dependency on the
`roleAssignmentScheduleRequests` API, so that role assignments will not
become unmanageable over time
([#25956](https://github.com/hashicorp/terraform-provider-azurerm/issues/25956))&#xA;*
`azurerm_pim_eligible_role_assignment` - remove hard dependency on the
`roleEligibilityScheduleRequests` API, so that role assignments will not
become unmanageable over time
([#25956](https://github.com/hashicorp/terraform-provider-azurerm/issues/25956))&#xA;*
`azurerm_windows_function_app` - support for the PowerShell `7.4`
([#25980](https://github.com/hashicorp/terraform-provider-azurerm/issues/25980))&#xA;&#xA;BUG
FIXES:&#xA;&#xA;* `azurerm_container_app_job` - Allow
`event_trigger_config.scale.min_executions` to be `0`
([#25931](https://github.com/hashicorp/terraform-provider-azurerm/issues/25931))&#xA;*
`azurerm_container_app_job` - update validation to allow the
`replica_retry_limit` property to be set to `0`
([#25984](https://github.com/hashicorp/terraform-provider-azurerm/issues/25984))&#xA;*
`azurerm_data_factory_trigger_custom_event` - one of
`subject_begins_with` and `subject_ends_with` no longer need to be set
([#25932](https://github.com/hashicorp/terraform-provider-azurerm/issues/25932))&#xA;*
`azurerm_kubernetes_cluster_node_pool` - prevent race condition by
checking the virtual network status when creating a node pool with a
subnet ID
([#25888](https://github.com/hashicorp/terraform-provider-azurerm/issues/25888))&#xA;*
`azurerm_postgresql_flexible_server` - fix for default `storage_tier`
value when `storage_mb` field has been changed
([#25947](https://github.com/hashicorp/terraform-provider-azurerm/issues/25947))&#xA;*
`azurerm_pim_active_role_assignment` - resolve a number of potential
crashes
([#25956](https://github.com/hashicorp/terraform-provider-azurerm/issues/25956))&#xA;*
`azurerm_pim_eligible_role_assignment` - resolve a number of potential
crashes
([#25956](https://github.com/hashicorp/terraform-provider-azurerm/issues/25956))&#xA;*
`azurerm_redis_enterprise_cluster_location_zone_support` - add `Central
India` zones support
([#26000](https://github.com/hashicorp/terraform-provider-azurerm/issues/26000))&#xA;*
`azurerm_sentinel_alert_rule_scheduled` - the
`alert_rule_template_version` property is no longer `ForceNew`
([#25688](https://github.com/hashicorp/terraform-provider-azurerm/issues/25688))&#xA;*
`azurerm_storage_sync_server_endpoint` - preventing a crashed due to
`initial_upload_policy`
([#25968](https://github.com/hashicorp/terraform-provider-azurerm/issues/25968))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/185/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_windows_function_app doesn't support powershell 7.4
3 participants