-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Caching feature in Azure Container Registry(ACR) #21258
Comments
Hey guys, any update on this, we hit the dockerhub rate limit lately.. |
I want to try implementing this as we also need it. Before starting however, we the go-azure-sdk needs to support the latest containerRegistry api (2023-01-01-preview), which includes support for caching. |
Since yesterday the go-azure-sdk supports apiversion 2023-07-01 of the containerregistry api, which has support for cacherules. Now the functionality can be implemented in the terraform provider. I am not sure when I will find time to start on it, so if someone else wants to give it a go, be my guest. More details can be found here |
@tombuildsstuff he ACR Cache rules are not our of preview and in production. Are you able to add support for it in terraform? |
We're longing for this as well, by September 30 new dockerhub rate limiting will come into effect and this would make things easier to manage. |
Hi there Did you find some time to work on it? @nclaeys |
@JoachimHansEDDI I did not get to it yet. Feel free to take it over, I am a bit swamped with other work in the coming weeks. |
I have no clue about development. ;-) |
Please, any update on this? |
Any update, currently a BIG gap in azurerm support IMHO |
I'm an independent contributor, started working on it! |
Thanks a lot @mhaligowski |
Morning @mhaligowski I see your PR https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fhashicorp%2Fterraform-provider-azurerm%2Fissues%2F21258 What/Who is the showstopper here or how is the process to get this merged? |
@JoachimHansEDDI evening, I'm still working on it! I think core of the development is done, I was able to run some base tests. The things left are:
I've been busy with my professional project, which actually requires this change! I hope to get it finished within the next two weeks, with some more spotty people's availability over the holidays. Sorry if this is putting you in an inconvenient position, I'm working on it in my spare time. |
Hi @mhaligowski Did you find any time to push that forward? |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
There is currently looking that not supported by terraform yet. However I am using azapi terraform functions and it works. |
It's been a year since this feature was introduced 🎂 |
Heads-up that I've springboarded off @mhaligowski's work and have a PR ready for review. I've run the acceptance tests locally (and built the provider and poked around manually). Everything seems to work. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Is there an existing issue for this?
Community Note
Description
Caching for ACR allows you to create a cache rule and cache container images from Docker Hub and Microsoft Artifact Registry. Caching images lets you pull images directly from your cache ensuring faster and more reliable pull operations.
New or Affected Resource(s)/Data Source(s)
azurerm_container_registry
Potential Terraform Configuration
References
https://aka.ms/acr/cache
The text was updated successfully, but these errors were encountered: