Azure batch expose keys and account url #3071
Conversation
ghost
added
There was a problem hiding this comment.
Hin @Lucretius,
Thanks for the PR, aside from two minor comments iv'e left inline this LGTM 👍
I hope you don't mind but i am going to push a commit to fix them to get this merged 🙂
azurerm/data_source_batch_account.go
Outdated
| keys, err := client.GetKeys(ctx, resourceGroup, name) | ||
|
|
||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
Could we wrap this error?
| return err | |
| return fmt.Errorf("Error getting kets for Batch Account %q (Resource Group %q): %+v", name, resourceGroup, err) |
| keys, err := client.GetKeys(ctx, resourceGroupName, name) | ||
|
|
||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
Could we wrap this error?
| return err | |
| return fmt.Errorf("Error getting kets for Batch Account %q (Resource Group %q): %+v", name, resourceGroup, err) |
|
This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.24.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
This PR exposes the primary access key, secondary access key and account endpoint in the
azurerm_batch_accountresource and data_source. The documentation has also been updated, with a note that the keys are only available when the batch accountspool_allocation_modeisBatchService. If the allocation mode isUserSubscription, terraform will throw an error.