Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source/Resource: azurerm_stream_analytics_job #3227

Merged
merged 4 commits into from Apr 16, 2019

Conversation

tombuildsstuff
Copy link
Member

@tombuildsstuff tombuildsstuff commented Apr 10, 2019

This PR adds support for Stream Analytics Jobs - which were previously worked on by @shelleybess in #888.

After some investigation into Stream Analytics it appears that it's possible to only have a single Transformation per Stream Analytics Job - as such I've ended up taking a slightly different approach to #888 by rolling this up within the Stream Analytics Job resource.

Tests pass:

$ acctests azurerm TestAccAzureRMStreamAnalyticsJob_
=== RUN   TestAccAzureRMStreamAnalyticsJob_basic
=== PAUSE TestAccAzureRMStreamAnalyticsJob_basic
=== RUN   TestAccAzureRMStreamAnalyticsJob_requiresImport
--- SKIP: TestAccAzureRMStreamAnalyticsJob_requiresImport (0.00s)
    resource_arm_stream_analytics_job_test.go:40: Skipping since resources aren't required to be imported
=== RUN   TestAccAzureRMStreamAnalyticsJob_update
=== PAUSE TestAccAzureRMStreamAnalyticsJob_update
=== CONT  TestAccAzureRMStreamAnalyticsJob_basic
--- PASS: TestAccAzureRMStreamAnalyticsJob_basic (107.29s)
=== CONT  TestAccAzureRMStreamAnalyticsJob_update
--- PASS: TestAccAzureRMStreamAnalyticsJob_update (203.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	311.787s

@tombuildsstuff tombuildsstuff changed the title [WIP] New Data Source/Resource: azurerm_stream_analytics_job New Data Source/Resource: azurerm_stream_analytics_job Apr 15, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one documentation comment LGTM 👍

website/docs/r/stream_analytics_job.html.markdown Outdated Show resolved Hide resolved
@katbyte katbyte self-assigned this Apr 16, 2019
@katbyte katbyte merged commit 6d9fb2c into master Apr 16, 2019
@katbyte katbyte deleted the f/stream-analytics branch April 16, 2019 03:35
katbyte added a commit that referenced this pull request Apr 16, 2019
katbyte pushed a commit that referenced this pull request Apr 16, 2019
This PR adds support for Stream Analytics Functions; of which at this time we can only support JavaScript UDF functions

Dependent on #3227
katbyte pushed a commit that referenced this pull request Apr 16, 2019
This PR adds support for:

- [x] New Resource: `azurerm_stream_analytics_output_blob`
- [x] New Resource: `azurerm_stream_analytics_output_eventhub`
- [x] New Resource: `azurerm_stream_analytics_output_servicebus_queue`

Dependent on #3249 and #3227
@ghost
Copy link

ghost commented Apr 17, 2019

This has been released in version 1.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.25.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 16, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants