New Resource & Datasources: azurerm_automation_variable_[bool|datetime|string|int]

[WodansSon]

I would normally have these as individual PR's but they all share a common function so I had to bundle them all up into a single PR.

(fixes #1312)

[katbyte]

Hi @jeffreyCline,

Thank you for the PR. I've left some comments inline but my main question is why 5 separate resources for the same client & API call? Unless I am missing something these are almost identical, call the same API just take a different type of value parameter.

Wouldn't a single resource that takes a string value for value (matching the API) and then possible a type property of int|bool|datetime|ect that then triggers the correct validation for that property be far simpler and easier to maintain? I am not sure what you gain with the current design.

I can see the types in the portal but all that seems to do is just change how the frontend looks & maybe some validation.

[katbyte]

Thanks for the updates @jeffreyCline, looks much better!

just a couple more comments i've left inline

[WodansSon]

All resource and data source tests pass.

[katbyte]

Aside from two minor comments this looks good to me now @jeffreyCline ! thanks

New Resource: azurerm_automation_string_variable, azurerm_automation_bool_variable, azurerm_automation_int_variable, azurerm_automation_datetime_variable and data sources (#3310)

[WodansSon]

Thanks @katbyte for updating the naming... made 4 suggestions, other than that LGTM! 👍

[ghost]

This has been released in version 1.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.28.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!