Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: azurerm_stream_analytics_output_eventhub does not set the output format #3318

Merged

Conversation

maxbog
Copy link
Contributor

@maxbog maxbog commented Apr 26, 2019

No description provided.

@ghost ghost added the size/S label Apr 26, 2019
@maxbog maxbog force-pushed the f/bugfix_stream_analytics_output_format branch 2 times, most recently from d5a0362 to 0d8cb5f Compare April 26, 2019 13:05
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @maxbog,

Aside from one minor comment i've left inline this looks good

Config: testAccAzureRMStreamAnalyticsOutputEventHub_jsonArrayFormat(ri, location),
Check: resource.ComposeTestCheckFunc(
testCheckAzureRMStreamAnalyticsOutputEventHubExists(resourceName),
),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add some checks here:

resource.TestCheckResourceAttr(resourceName, "serialization.0.format", "Array"),

and for the rest of the serialization block

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done here and for all other types of serialization

@maxbog maxbog force-pushed the f/bugfix_stream_analytics_output_format branch from 0d8cb5f to 2a62ad5 Compare April 29, 2019 12:07
@ghost ghost added size/M and removed size/S labels Apr 29, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! LGTM 👍

katbyte added a commit that referenced this pull request Apr 29, 2019
@katbyte katbyte merged commit 8881153 into hashicorp:master Apr 29, 2019
@ghost
Copy link

ghost commented May 17, 2019

This has been released in version 1.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.28.0"
}
# ... other configuration ...

@ghost ghost removed the waiting-response label May 17, 2019
@ghost
Copy link

ghost commented May 30, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators May 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants