Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_application_gateway: fix panic in backend and probe pick hostname validation #3438

Merged
merged 2 commits into from May 15, 2019

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented May 14, 2019

No description provided.

@katbyte katbyte added this to the v1.28.0 milestone May 14, 2019
@katbyte katbyte requested a review from a team May 14, 2019 23:35
@ghost ghost added the size/XS label May 14, 2019
@katbyte
Copy link
Collaborator Author

katbyte commented May 14, 2019

Fixes:

2019-05-13T16:35:34.203-0400 [DEBUG] plugin.terraform-provider-azurerm_v1.23.0_x4: panic: runtime error: index out of range
2019-05-13T16:35:34.203-0400 [DEBUG] plugin.terraform-provider-azurerm_v1.23.0_x4: 
2019-05-13T16:35:34.203-0400 [DEBUG] plugin.terraform-provider-azurerm_v1.23.0_x4: goroutine 477 [running]:
2019-05-13T16:35:34.203-0400 [DEBUG] plugin.terraform-provider-azurerm_v1.23.0_x4: github.com/terraform-providers/terraform-provider-azurerm/azurerm.flattenApplicationGatewayAuthenticationCertificates(0xc000566960, 0xc0007af0a0, 0x8, 0x2225ae0, 0xc000889360)
2019-05-13T16:35:34.203-0400 [DEBUG] plugin.terraform-provider-azurerm_v1.23.0_x4:  /opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-azurerm/azurerm/resource_arm_application_gateway.go:1143 +0x55b
2019-05-13T16:35:34.203-0400 [DEBUG] plugin.terraform-provider-azurerm_v1.23.0_x4: github.com/terraform-providers/terraform-provider-azurerm/azurerm.resourceArmApplicationGatewayRead(0xc0007af0a0, 0x2583b20, 0xc0002e0000, 0xc0007af0a0, 0x0)
2019-05-13T16:35:34.203-0400 [DEBUG] plugin.terraform-provider-azurerm_v1.23.0_x4:  /opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-azurerm/azurerm/resource_arm_application_gateway.go:988 +0x644

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@katbyte katbyte merged commit 36ce9cc into master May 15, 2019
katbyte added a commit that referenced this pull request May 15, 2019
@katbyte katbyte changed the title azurerm_application_gateway: fix panic in backend and prob pick hostname validation azurerm_application_gateway: fix panic in backend and probe pick hostname validation May 15, 2019
@katbyte katbyte deleted the b/app_gateway_panic branch May 15, 2019 04:58
@ghost
Copy link

ghost commented May 17, 2019

This has been released in version 1.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.28.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 14, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants