Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_cosmosdb_mongo_collection #3459

Merged
merged 32 commits into from May 16, 2019
Merged

New Resource: azurerm_cosmosdb_mongo_collection #3459

merged 32 commits into from May 16, 2019

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented May 16, 2019 •
edited

fixes #548

@katbyte katbyte added this to the v1.28.0 milestone May 16, 2019
@ghost ghost added the size/XL label May 16, 2019
@ghost ghost added the documentation label May 16, 2019
@katbyte katbyte changed the title New Resource: azurerm_cosmosdb_mongo_database New Resource: azurerm_cosmosdb_mongo_collection May 16, 2019
mbfrahry
mbfrahry approved these changes May 16, 2019
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor comments

azurerm/resource_arm_cosmosdb_mongo_collection.go Outdated Show resolved Hide resolved
azurerm/resource_arm_cosmosdb_mongo_collection.go Outdated Show resolved Hide resolved
azurerm/resource_arm_cosmosdb_mongo_collection_test.go Outdated

indexes {
key = "seven"
unique = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting

website/docs/r/cosmosdb_mongo_collection.html.markdown Outdated Show resolved Hide resolved
website/docs/r/cosmosdb_mongo_collection.html.markdown Outdated Show resolved Hide resolved
website/docs/r/cosmosdb_mongo_collection.html.markdown Outdated Show resolved Hide resolved
@katbyte katbyte merged commit b758976 into master May 16, 2019
@katbyte katbyte deleted the cosmos/mongo-collections branch May 16, 2019 22:07
katbyte added a commit that referenced this pull request May 16, 2019
@katbyte
Update CHANGELOG,md to include #3459
1ab1c3d
@ghost
Copy link

ghost commented May 17, 2019

This has been released in version 1.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.28.0"
}
# ... other configuration ...

@ryancrawcour ryancrawcour mentioned this pull request May 28, 2019
Closed
@ghost
Copy link

ghost commented Jun 16, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jun 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
documentation new-resource service/cosmosdb size/XL
Projects
None yet
Milestone
v1.28.0
Development

Successfully merging this pull request may close these issues.

Feature Request: CosmosDB Collections
2 participants
@katbyte @mbfrahry