Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Windows Container in Azure App Service #3566

Merged

Conversation

jcorioland
Copy link
Contributor

@jcorioland jcorioland commented May 31, 2019

This PR brings support for Windows Container preview feature in Azure App Service.
It fixes #2999.

  • support windows container in resource_arm_app_service_plan and resource_arm_app_service
  • support windows container in data_source_app_service_plan and data_source_app_service
  • tests
  • documentation
  • example

@ghost ghost added the size/S label May 31, 2019
@ghost ghost added size/L and removed size/S labels May 31, 2019
@ghost ghost added documentation size/XL and removed size/L labels May 31, 2019
@jcorioland jcorioland changed the title [WIP] Support for Windows Container in Azure App Service Support for Windows Container in Azure App Service May 31, 2019
@jcorioland
Copy link
Contributor Author

Hello @tombuildsstuff @katbyte - this PR is ready for review :) Thanks!

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jcorioland

Thanks for this PR - this LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v1.30.0 milestone May 31, 2019
@katbyte katbyte merged commit 228a928 into hashicorp:master May 31, 2019
katbyte added a commit that referenced this pull request May 31, 2019
@ghost
Copy link

ghost commented Jun 20, 2019

This has been released in version 1.30.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.30.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_app_service windows container support
3 participants