Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for azurerm_app_service_plan to accommodate creation of Isolated SKUs that take a long time to provision #3737

Conversation

nmiodice
Copy link

@nmiodice nmiodice commented Jun 27, 2019

azurerm_app_service_plan resources that are created with an Isolated sku can take quite some time to create because they resources being created are not shared and take a long time to create within Azure itself.

This change increases the timeout to 3 hours when creating azurerm_app_service_plan resources. This covers nearly all of the scenarios, as most will create in <= 1.5 hours.

Note: I'm aware that this will be fixed by #171 but I thought that since this is an expected scenario that we should fix it up front

hours to create. This change increases the timeout to 3 hours to cover
the most common cases.
@ghost ghost added the size/XS label Jun 27, 2019
@nmiodice nmiodice changed the title Increase timeout for azurerm_app_service_plan to accommodate creation of Isolated SKUs Increase timeout for azurerm_app_service_plan to accommodate creation of Isolated SKUs that take a long time to provision Jun 27, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nmiodice,

Thanks for the PR. Upon internal discussion we decided it would be best to just updated the global default to 3 hours as there are some other resources that also are hitting timeouts. This should hold us over until we can properly thread in context/timeouts through all resources.

I hope you don't mind but i pushed those changes so we could get this merged 🙂

@katbyte katbyte added this to the v1.31.0 milestone Jun 27, 2019
@katbyte katbyte merged commit 5e4d392 into hashicorp:master Jun 27, 2019
katbyte added a commit that referenced this pull request Jun 27, 2019
@nmiodice nmiodice deleted the niiodice/features/app-service-plan-timeout-increase branch June 27, 2019 20:57
@nmiodice
Copy link
Author

Thanks @katbyte -- one question, this change looks slated for 1.31.0 which is unreleased according to https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/CHANGELOG.md. When will this actually release? What controls this release and how is the cadence set?

@ghost
Copy link

ghost commented Jun 28, 2019

This has been released in version 1.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.31.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 28, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Jul 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants