Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Function App - adding support for min TLS version and HTTPS Only #3740

Closed
alex-3sr opened this issue Jun 27, 2019 · 2 comments · Fixed by #5074
Closed

Azure Function App - adding support for min TLS version and HTTPS Only #3740

alex-3sr opened this issue Jun 27, 2019 · 2 comments · Fixed by #5074

Comments

@alex-3sr
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Hi,

Like for azurerm_app_service we really need to set min_tls_version for azurerm_function_app.
See #1601

Error :
2019-06-27T13:38:33.2907377Z on main.tf line 90, in resource "azurerm_function_app" "functionapp":
2019-06-27T13:38:33.2908000Z 90: min_tls_version = "1.2"
2019-06-27T13:38:33.2908148Z
2019-06-27T13:38:33.2908745Z An argument named "min_tls_version" is not expected here.

Thank you,
Alex

New or Affected Resource(s)

  • azurerm_function_app

Potential Terraform Configuration

resource "azurerm_function_app" "functionapp" {
  name                      = "AFA-01"
  location                  = "${azurerm_resource_group.rgproject.location}"
  resource_group_name       = "${azurerm_resource_group.rgproject.name}"
  app_service_plan_id       = "${azurerm_app_service_plan.planafa.id}"
  storage_connection_string = "${azurerm_storage_account.storage.primary_connection_string}"
  version                   = "~2"
  https_only                = true

    site_config {
        min_tls_version = "1.2"
    }

  lifecycle {
    prevent_destroy = true
    ignore_changes = [
         "app_settings.FUNCTIONS_EXTENSION_VERSION"
     ]
  }
}

References

  • #0000
@aqche
Copy link
Contributor

aqche commented Dec 5, 2019

Looks like https_only is supported now. Opened a PR to add support for min_tls_version.

@ghost
Copy link

ghost commented Jan 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants