Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Azure Go SDK to v31.0.0 #3786

Merged
merged 6 commits into from Jul 9, 2019
Merged

Upgrade Azure Go SDK to v31.0.0 #3786

merged 6 commits into from Jul 9, 2019

Conversation

moserda
Copy link
Contributor

@moserda moserda commented Jul 4, 2019

To enable implementation of #3755 I'd like to upgrade the Azure Go SDK dependency to 31.0.0

@moserda moserda mentioned this pull request Jul 4, 2019
Merged
katbyte
katbyte previously requested changes Jul 6, 2019
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dmoser04,

Thank you for the PR, my only comment is that we shouldn't be updating the SDK and changing and API version in the same PR.

We are also waiting for a new version of go-autorest and the SDK to be released so I'd like to wait on those to now have to run and review the full acceptance test suite.

@katbyte katbyte added this to the v1.32.0 milestone Jul 6, 2019
@moserda
Copy link
Contributor Author

moserda commented Jul 6, 2019

Hi @katbyte

Thank you for your comment. I reverted the update of the containerservice API

@ghost ghost removed the waiting-response label Jul 6, 2019
tombuildsstuff
tombuildsstuff approved these changes Jul 9, 2019
View reviewed changes
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @dmoser04

@tombuildsstuff tombuildsstuff dismissed katbyte’s stale review July 9, 2019 04:46

dismissing since changes have been pushed

katbyte
katbyte approved these changes Jul 9, 2019
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @dmoser04! Tests look good

@katbyte katbyte merged commit 346f287 into hashicorp:master Jul 9, 2019
@moserda moserda deleted the features/update-azure-sdk-to-v31 branch July 9, 2019 19:33
katbyte added a commit that referenced this pull request Jul 9, 2019
@katbyte
Update CHANGeLOG.md to include #3786
682559c
katbyte pushed a commit that referenced this pull request Jul 10, 2019
@moserda @katbyte
[azurerm_kubernetes_cluster ] - support for the node_taints p… (#3787)
901c9ef 
This small PR adds support for defining Kubernetes taints in AKS agent_pool_profiles as requested in #3755.

However the PR depends on an upgrade of the Azure Go SDK to 31.0.0 (see #3786)

(fixes #3755)
@ghost
Copy link

ghost commented Jul 30, 2019

This has been released in version 1.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.32.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 9, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
dependencies size/XXL
Projects
None yet
Milestone
v1.32.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@moserda @tombuildsstuff @katbyte