Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azurerm_kubernetes_cluster ] - support for the node_taints property #3787

Merged
merged 8 commits into from Jul 10, 2019

Conversation

moserda
Copy link
Contributor

@moserda moserda commented Jul 4, 2019

This small PR adds support for defining Kubernetes taints in AKS agent_pool_profiles as requested in #3755.

However the PR depends on an upgrade of the Azure Go SDK to 31.0.0 (see #3786)

(fixes #3755)

# Conflicts:
#	azurerm/internal/services/containers/client.go
#	azurerm/resource_arm_kubernetes_cluster.go
#	azurerm/resource_arm_kubernetes_cluster_test.go
@moserda moserda changed the title Add node_taints for AKS agent_pool_profile [WIP] Add node_taints for AKS agent_pool_profile Jul 4, 2019
@ghost ghost added size/XL dependencies and removed size/M labels Jul 9, 2019
@moserda moserda changed the title [WIP] Add node_taints for AKS agent_pool_profile Add node_taints for AKS agent_pool_profile Jul 9, 2019
@katbyte katbyte added this to the v1.32.0 milestone Jul 10, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the enhancement @dmoser04! LGTM 🙂

@katbyte katbyte changed the title Add node_taints for AKS agent_pool_profile [azurerm_kubernetes_cluster ] - support for the node_taints property Jul 10, 2019
@katbyte katbyte merged commit 901c9ef into hashicorp:master Jul 10, 2019
katbyte added a commit that referenced this pull request Jul 10, 2019
@moserda moserda deleted the features/aks-node-taints branch July 10, 2019 18:23
@ghost
Copy link

ghost commented Jul 30, 2019

This has been released in version 1.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.32.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 10, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provision to pass taint value for the agents in AKS cluster
2 participants