Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_app_service: support for storage mounts #3792

Merged
merged 1 commit into from Jul 5, 2019
Merged

azurerm_app_service: support for storage mounts #3792

merged 1 commit into from Jul 5, 2019

Conversation

joakimhellum
Copy link

Fixes #2247

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @joakimhellum-in, LGTM 👍

@katbyte katbyte merged commit d8a4bb6 into hashicorp:master Jul 5, 2019
katbyte added a commit that referenced this pull request Jul 5, 2019
@joakimhellum joakimhellum deleted the f/webapp-storage-mount branch July 5, 2019 05:17
@joakimhellum joakimhellum restored the f/webapp-storage-mount branch July 5, 2019 07:16
@bentterp
Copy link
Contributor

bentterp commented Jul 8, 2019

The documentation for this new feature has the access key as required parameter.
I think it would be super great if we could use user-assigned identities (#3637) as an alternative.

That would reduce the amount of key rotations needed - always makes people nervous when we have to do that.

@ghost
Copy link

ghost commented Jul 30, 2019

This has been released in version 1.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.32.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Aug 4, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Bring Your Own Storage for Web Apps
3 participants