Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_monitor_action_group - add support for the use_common_alert_schema webhook property #4483

Merged
merged 7 commits into from Oct 15, 2019
Merged

azurerm_monitor_action_group - add support for the use_common_alert_schema webhook property #4483

merged 7 commits into from Oct 15, 2019

Conversation

phires
Copy link
Contributor

@phires phires commented Oct 2, 2019 •
edited by katbyte

Updated Azure SDK API for insights to 2019-06-01 to be able to use the option 'UseCommonAlertSchema'

(fixs #3363)

@phires
Added option for Common Alert Schema to Webhooks (#3363)
dbc9b4d 
Updated Azure SDK API for insights to 2019-06-01
@phires
Copy link
Contributor Author

phires commented Oct 2, 2019

Build seems to fail, because travis does not know / import the updated dependency https://github.com/Azure/azure-sdk-for-go/tree/master/services/preview/monitor/mgmt/2019-06-01/insights
Any way for me to fix this?

@mbfrahry
Copy link
Member

mbfrahry commented Oct 2, 2019

Hey @phires, dependencies are updated manually so you'll have to do this yourself. The below should do the trick

go get github.com/Azure/azure-sdk-for-go/services/preview/monitor/mgmt/2019-06-01/insights
go mod tidy
go mod vendor

@katbyte katbyte added this to the v1.36.0 milestone Oct 5, 2019
@ghost ghost added size/XL and removed size/M labels Oct 7, 2019
@phires
Copy link
Contributor Author

phires commented Oct 8, 2019

Fix is commited, anythint I can do to resolve the conflicts?

@ghost ghost removed the waiting-response label Oct 8, 2019
@ghost
Copy link

ghost commented Oct 8, 2019

Fix is commited, anythint I can do to resolve the conflicts?

You can merge the latest master to your branch to resolve these conflicts: https://stackoverflow.com/questions/26241428/this-pull-request-contains-merge-conflicts-that-must-be-resolved
Let me know if you need more help on this.

I am looking forward to seeing this feature in v1.36.0.

@ghost ghost added size/XXL and removed size/XL labels Oct 9, 2019
@phires
Copy link
Contributor Author

phires commented Oct 9, 2019

Finally :) Thank you all, I'm learning something new every day!

@ghost ghost removed the waiting-response label Oct 9, 2019
katbyte
katbyte requested changes Oct 10, 2019
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phires, It seems like there are an excessive number of changes in this PR? many vendored in packages are being removed.. i'm not sure that is accurate? i tried to fix things locally but i can't push to your branch

@phires
Copy link
Contributor Author

phires commented Oct 10, 2019

@katbyte Well, I guess I have to read up on all those "mod" stuff...
I've added you as a collaborator to my repository, your help is highly appreciated :)

@ghost ghost removed the waiting-response label Oct 10, 2019
@ghost
Copy link

ghost commented Oct 14, 2019

@phires Can you also add me as a collaborator to your repo? I will try to sort it out with the missing files.

@ghost ghost added size/XL and removed size/XXL labels Oct 15, 2019
katbyte
katbyte approved these changes Oct 15, 2019
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phires!

I've merged master & that fixed up the diff, LGTM now 👍

@katbyte katbyte changed the title Added option for Common Alert Schema to Webhooks (#3363) azurerm_monitor_action_group - add support for the use_common_alert_schema webhook property Oct 15, 2019
@katbyte katbyte merged commit 268f581 into hashicorp:master Oct 15, 2019
katbyte added a commit that referenced this pull request Oct 15, 2019
@katbyte
Update CHANGELOG.md to include #4483
0740e7b
@mcdafydd mcdafydd mentioned this pull request Oct 16, 2019
Closed
mcdafydd added a commit to mcdafydd/terraform-provider-azurerm that referenced this pull request Oct 16, 2019
@mcdafydd
Fixes hashicorp#3603 and comments
3855aa3 
- Adds arm_role_receiver
- Adds use_common_alert_schema to all supported receivers
- Changes require insights import change from hashicorp#4483
This was referenced Oct 16, 2019
Merged
Closed
@ghost
Copy link

ghost commented Oct 29, 2019

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 14, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
dependencies documentation enhancement service/application-insights size/XL
Projects
None yet
Milestone
v1.36.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phires @mbfrahry @katbyte