Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_client_config - add object_idproperty #4486

Merged
merged 10 commits into from Oct 3, 2019
Merged

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Oct 2, 2019

fixes #3234

@katbyte katbyte added this to the v1.35.0 milestone Oct 2, 2019
@katbyte katbyte requested a review from a team October 2, 2019 16:18
"subscription_id": {
Type: schema.TypeString,
Computed: true,
},
"service_principal_application_id": {

"authenticated_object_id": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this'd make more sense as object_id?

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment about adding deprecated fields to the upgrade guide


---

~> **Note:** the following fields are only available when authenticating via a Service Principal (as opposed to using the Azure CLI):
~> **Note:** the following fields are only available when authenticating via a Service Principal (as opposed to using the Azure CLI) and have been deprecated:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add these deprecated fields to the Upgrade Guide for 2.0 https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/website/docs/guides/2.0-upgrade-guide.html.markdown if we haven't already

@katbyte katbyte merged commit 0c85ec8 into master Oct 3, 2019
@katbyte katbyte deleted the clientconfig_object_id branch October 3, 2019 02:44
@katbyte katbyte changed the title azurerm_client_config - add authenticated_object_idproperty azurerm_client_config - add object_idproperty Oct 3, 2019
katbyte added a commit that referenced this pull request Oct 3, 2019
@ghost
Copy link

ghost commented Oct 4, 2019

This has been released in version 1.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.35.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Get object_id of current user
3 participants