Feature: data source for PostgreSQL

[booyaa]

Status: I've got to finish the documentation.

Questions for reviewers:

• In myTestAccDataSourceAzureRMPPostgreSqlServer_basic test, I've hard coded to use version 9.5, would you prefer I create basic tests for all versions supported?
• Do I need to commit my go.sum?

Closes #4662

[tombuildsstuff]

hey @booyaa

Thanks for this PR :)

Taking a look through this is looking good if we can fix up the minor comments this otherwise LGTM 👍.

To answer your questions:

In myTestAccDataSourceAzureRMPPostgreSqlServer_basic test, I've hard coded to use version 9.5, would you prefer I create basic tests for all versions supported?

That's fine, the response would be the same for all the versions so we're good here 👍

Do I need to commit my go.sum?

Not in this instance - since there's no changes to the vendored files. Likely your editor has been working against a slightly more up to date version of the Azure SDK for Go than we're using rather than the vendored SDK; but that's fine.

Thanks!

[booyaa]

Thanks for the feedback @tombuildsstuff updated as per comments :)

[booyaa]

it looks like tflint is failing, that's probably from me just accepting the suggested changes. I'll pull the code down and fix the errors.

[tombuildsstuff]

Test passes:

[tombuildsstuff]

Thanks for pushing those changes @booyaa this now LGTM 👍

[ghost]

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!