Implement azurerm_automation_certificate

[dowlingw]

Implement azurerm_automation_certificate as requested in #3881

Overview of changes:

• Added CertificateClient to automation client
• Implemented new resource type azurerm_automation_certificate
• Resource documentation for website

Notes
This is my first attempt at Terraform provider code, any feedback about how this could be done better or differently would be appreciated.

I've elected to set Computed: true on the is_exportable and thumbprint resource properties, even though these can be set on the Create/Update calls - these are extracted from the provided certificate and returned in any REST responses. I've validated this for the thumbprint property but not for is_exportable. I can't imagine anyone would need to doubly specify this.

[katbyte]

Thanks for the new resource @dowlingw,

Overall this is off to a great start! i've left some comments inline that need to be addressed before merge

[dowlingw]

I think this should be ready to go, please have a look and let me know if you've got any further feedback <3

[tombuildsstuff]

hey @dowlingw

Thanks for this PR - apologies for the delayed review here!

Taking a look through this looks pretty good - I've left some minor comments inline (which, I hope you don't mind but I'm going to push a commit to fix & rebase this on top of master so that we can get this merged) - but this is otherwise looking good to me 👍

Thanks!

[tombuildsstuff]

Tests pass:

$ acctests azurerm TestAccAzureRMAutomationCertificate_
=== RUN   TestAccAzureRMAutomationCertificate_basic
=== PAUSE TestAccAzureRMAutomationCertificate_basic
=== RUN   TestAccAzureRMAutomationCertificate_requiresImport
--- SKIP: TestAccAzureRMAutomationCertificate_requiresImport (0.00s)
    resource_arm_automation_certificate_test.go:44: Skipping since resources aren't required to be imported
=== RUN   TestAccAzureRMAutomationCertificate_complete
=== PAUSE TestAccAzureRMAutomationCertificate_complete
=== RUN   TestAccAzureRMAutomationCertificate_update
--- PASS: TestAccAzureRMAutomationCertificate_update (201.07s)
=== CONT  TestAccAzureRMAutomationCertificate_basic
--- PASS: TestAccAzureRMAutomationCertificate_basic (109.49s)
=== CONT  TestAccAzureRMAutomationCertificate_complete
--- PASS: TestAccAzureRMAutomationCertificate_complete (107.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	418.130s

dismissing since changes have been pushed

[dowlingw]

No problems whatsoever, thanks for sorting those out - cheers :)

[ghost]

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!