New Resource & Data Source: azurerm_netapp_pool
#4889
Conversation
ghost
added
There was a problem hiding this comment.
Hey @neil-yechenwei, thanks for opening this PR. It's mostly there and the main thing to discuss would be size and making it a little more user friendly
There was a problem hiding this comment.
Hi @neil-yechenwei,
Looking pretty good here, i've left some comments in addition to matthews tht should be addressed.
azurerm/data_source_netapp_pool.go
Outdated
| ValidateFunc: validation.StringMatch( | ||
| regexp.MustCompile(`^[\da-zA-Z_-]{4,64}$`), | ||
| `The name must be between 4 and 64 characters in length and contain only letters, numbers, underscore or hyphens.`, | ||
| ), |
There was a problem hiding this comment.
could we make this a shared function in the netapp package and share it with the resource?
There was a problem hiding this comment.
Fixed. Moved this validation to netapp package as shared function.
azurerm/data_source_netapp_pool.go
Outdated
| "account_name": { | ||
| Type: schema.TypeString, | ||
| Required: true, | ||
| ValidateFunc: validation.StringMatch( |
There was a problem hiding this comment.
could we make this a shared function in the netapp package and share it with the resource and netapp account resource?
There was a problem hiding this comment.
Fixed. Moved this validation to netapp package as shared function.
|
@mbfrahry , Thanks for your comments. I've updated code. |
mbfrahry
changed the title
azurerm_netapp_pool
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
This PR is code implement for issue #3936