[Networking] Updating to 2019-09-01 / fixing azurerm_virtual_hub / VPN Resources

[tombuildsstuff]

We ultimately ended up pulling the azurerm_virtual_hub Data Source & Resource from v1.37 since the resource design didn't match how the API worked. As such this PR reintroduces the azurerm_virtual_hub resource by introducing the dependencies necessary to use it.

Whilst it's unfortunate this PR is so large - due to the fact that this is already merged it makes sense to bundle these together - however traditionally we'd split these apart, in particular the SDK upgrade.

This PR includes:

• updating the network API to 2019-09-01
• re-introducing the azurerm_virtual_hub Data Source / Resources:
  • removing the express_route_gateway_id field from the Data Source & Resource
  • removing the p2s_vpn_gateway_id field from the Data Source & Resource
  • removing the s2s_vpn_gateway_id field from the Data Source & Resource
  • removing the route block from the Data Source
  • removing the virtual_network_connection block from the Data Source & Resource
• removing the security_provider_name field from the azurerm_virtual_wan resource since this is no longer available in the API
• New Resource: azurerm_point_to_site_vpn_gateway
• New Resource: azurerm_vpn_gateway
• New Resource: azurerm_vpn_server_configuration

---

Acceptance Test Results:

Data Source: azurerm_virtual_hub:

Data Source: azurerm_virtual_wan:

Resource: azurerm_point_to_site_vpn_gateway:

Resource: azurerm_virtual_hub:

Resource: azurerm_virtual_hub_connection:

Resource: azurerm_vpn_gateway:

Resource: azurerm_vpn_server_configuration:

Resource: azurerm_virtual_wan:

[katbyte]

Aside from some minor comments LGTM 👍

[tombuildsstuff]

Acceptance Tests still pass after PR updates 👍

[neil-yechenwei]

Hi @tombuildsstuff , thanks for this PR. However, I have a question about this. I remember you wanna make the property "virtual_network_connection" as separate resource. But in this PR, I didn't find the separate resource for this property. Seems that this property has been removed from the resource. Maybe I missed something. Can I know the reason why this property should be removed?

[tombuildsstuff]

@neil-yechenwei it turns out the API doesn't work so we had to pull it

[ghost]

This has been released in version 1.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.38.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!