azurerm_api_management_api - correctly setting the soap API type when soap_pass_through is true
#5081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not completely sure if the modified block (line 222-229) is 100 % correct. Not sure if there can be other combinations of those properties. The change has been tested and verified locally for both soap_pass_through = true and false Fixes hashicorp#5080 Details in PR
ghost
added
the
|
@torresdal Do you want to have a look? |
|
@tnicolaysen been a long time since I contributed here, so better leave that to the great folks at HashiCorp 😊 (cc @tombuildsstuff) |
katbyte
changed the title
soap_pass_through will not correctly set the soap API type property
katbyte
approved these changes
Dec 19, 2019
katbyte
changed the title
soap_pass_through will not correctly set the soap API type propertysoap_pass_through is true
katbyte
added a commit
that referenced
this pull request
Dec 19, 2019
|
This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.40.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not completely sure if the modified block (line 222-229) is 100 % correct.
Not sure if there can be other combinations of those properties.
The change has been tested and verified locally for both soap_pass_through = true and false
Fixes #5080
Details in PR