Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_virtual_network_gateway_connection - add "connection_protocol" property #5145

Merged
merged 5 commits into from Dec 18, 2019

Conversation

phires
Copy link
Contributor

@phires phires commented Dec 12, 2019

This fixes #5144

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @phires

Thanks for this PR :)

Taking a look through this mostly LGTM - if we can add a test and fix up the minor comments then this otherwise should be good 👍🏻

Thanks!

@ghost ghost added size/M and removed size/XS labels Dec 13, 2019
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing those changes @phires

@katbyte katbyte changed the title added option "connection_protocol" to vnetgw conn azurerm_virtual_network_gateway_connection - add "connection_protocol" property Dec 18, 2019
@katbyte katbyte added this to the v1.40.0 milestone Dec 18, 2019
@katbyte katbyte merged commit f72c2c8 into hashicorp:master Dec 18, 2019
katbyte added a commit that referenced this pull request Dec 18, 2019
@phires phires deleted the vnetgw-conn-prot branch December 18, 2019 09:39
@tombuildsstuff
Copy link
Member

Tests pass:

Screenshot 2019-12-18 at 10 53 43

@ghost
Copy link

ghost commented Jan 8, 2020

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for connection_protocol in vnet gateway connection
3 participants