Add new resource & data source: azurerm_netapp_snapshot #5215
Conversation
ghost
added
There was a problem hiding this comment.
Hi @neil-yechenwei,
Thank you for the PR, i've left some mostly minor comments inline to address. I also do wonder if we should eport the filesystem id? is it useful to the user?
| { | ||
| Config: testAccAzureRMNetAppSnapshot_requiresImport(ri, testLocation()), | ||
| ExpectError: testRequiresImportError("azurerm_netapp_snapshot"), | ||
| }, |
There was a problem hiding this comment.
and this can become - data.RequiresImportErrorStep(testAccAzureRMNetAppSnapshot_requiresImport),
|
|
||
| * `location` - The Azure Region where the NetApp Snapshot exists. | ||
|
|
||
| * `file_system_id` - UUID v4 used to identify the FileSystem. |
There was a problem hiding this comment.
Does it make sense to export this?
There was a problem hiding this comment.
It's not useful to user since this field is also not required for creating this resource on azure portal.
| @@ -51,3 +51,5 @@ The following attributes are exported: | |||
| * `subnet_id` - The ID of a Subnet in which the NetApp Volume resides. | |||
|
|
|||
| * `storage_quota_in_gb` - The maximum Storage Quota in Gigabytes allowed for a file system. | |||
|
|
|||
| * `file_system_id` - The ID of the file system. | |||
There was a problem hiding this comment.
Does it make sense to export this?
There was a problem hiding this comment.
Same as above reason
|
|
||
| * `location` - (Required) Specifies the supported Azure location where the resource exists. Changing this forces a new resource to be created. | ||
|
|
||
| * `file_system_id` - (Optional) UUID v4 used to identify the FileSystem. |
There was a problem hiding this comment.
This is exported not an argument? also does it make sense?
There was a problem hiding this comment.
Same as above reason
|
Hi @katbyte , Thanks for your comments. I've updated code per your comments. |
|
This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.40.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
This PR is the code implement of the issue #5216