Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data source for azurerm_api_management_api_version_set #5470

Merged

Conversation

neil-yechenwei
Copy link
Contributor

Fix the issue of #5217

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @neil-yechenwei, only a few comments i've left inline that need to be addressed


* `resource_group_name` - (Required) The name of the Resource Group in which the parent API Management Service exists.

* `api_management_name` - (Required) The name of the [API Management Service](api_management.html) in which the API Version Set should exist.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `api_management_name` - (Required) The name of the [API Management Service](api_management.html) in which the API Version Set should exist.
* `api_management_name` - (Required) The name of the [API Management Service](api_management.html) in which the API Version exists.


* `display_name` - The display name of this API Version Set.

* `versioning_schema` - The value that determines where the API Version identifer will be located in a HTTP request. Possible values are `Header`, `Query` and `Segment`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to state the possible values for data sources

Suggested change
* `versioning_schema` - The value that determines where the API Version identifer will be located in a HTTP request. Possible values are `Header`, `Query` and `Segment`.
* `versioning_schema` - The value that determines where the API Version identifier will be located in a HTTP request.


```hcl
data "azurerm_api_management_api_version_set" "example" {
resource_group_name = "acctestRG"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use example names here

Suggested change
resource_group_name = "acctestRG"
resource_group_name = "example-resources"

```hcl
data "azurerm_api_management_api_version_set" "example" {
resource_group_name = "acctestRG"
api_management_name = "acctestApiManagement"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
api_management_name = "acctestApiManagement"
api_management_name = "example-api-management"

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope you don't mind but i've pushed the required changes to merge this, LGTM now 👍

@katbyte katbyte modified the milestones: v1.43.0, v1.42.0 Jan 25, 2020
@katbyte katbyte merged commit bef7737 into hashicorp:master Jan 25, 2020
katbyte added a commit that referenced this pull request Jan 25, 2020
@ghost
Copy link

ghost commented Jan 27, 2020

This has been released in version 1.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.42.0"
}
# ... other configuration ...

@ghost ghost removed the waiting-response label Jan 27, 2020
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants