azurerm_cosmosdb_sql_container - support for default_ttl

[aqche]

Fixes #5451

Adds the default_ttl argument for the azurerm_cosmosdb_sql_container resource.

Also, fixes a bug causing resource updates to fail since id.Container was being passed in instead of id.ResourceGroup for one of the function arguments.

--- PASS: TestAccAzureRMCosmosDbSqlContainer_complete (1108.43s)
--- PASS: TestAccAzureRMCosmosDbSqlContainer_basic (1109.64s)
--- PASS: TestAccAzureRMCosmosDbSqlContainer_update (1348.86s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/cosmos/tests        1348.94

[katbyte]

Thanks for the pr @aqche, this LGTM! 👍

[katbyte]

It looks like the tests are failing? 🤔

Test Failed

------- Stdout: -------
=== RUN   TestAccAzureRMCosmosDbSqlContainer_basic
=== PAUSE TestAccAzureRMCosmosDbSqlContainer_basic
=== CONT  TestAccAzureRMCosmosDbSqlContainer_basic
--- FAIL: TestAccAzureRMCosmosDbSqlContainer_basic (1293.56s)
    testing.go:569: Step 0 error: Check failed: 1 error occurred:
        	* Check 1/1 error: Bad: Get on cosmosAccountsClient: documentdb.DatabaseAccountsClient#GetSQLContainer: Failure responding to request: StatusCode=404 -- Original Error: autorest/azure: Service returned an error. Status=404 Code="ResourceNotFound" Message="The Resource 'Microsoft.DocumentDB/databaseAccounts/acctest-200123162126243972' under resource group 'acctestRG-cosmos-200123162126243972' was not found."

[aqche]

hmm strange, i'm able to run the tests w/o any issues... i'll poke around and see if I can discover anything.

=== RUN   TestAccAzureRMCosmosDbSqlContainer_basic
=== PAUSE TestAccAzureRMCosmosDbSqlContainer_basic
=== RUN   TestAccAzureRMCosmosDbSqlContainer_complete
=== PAUSE TestAccAzureRMCosmosDbSqlContainer_complete
=== RUN   TestAccAzureRMCosmosDbSqlContainer_update
=== PAUSE TestAccAzureRMCosmosDbSqlContainer_update
=== CONT  TestAccAzureRMCosmosDbSqlContainer_basic
=== CONT  TestAccAzureRMCosmosDbSqlContainer_update
=== CONT  TestAccAzureRMCosmosDbSqlContainer_complete
--- PASS: TestAccAzureRMCosmosDbSqlContainer_basic (1111.22s)
--- PASS: TestAccAzureRMCosmosDbSqlContainer_complete (1149.33s)
--- PASS: TestAccAzureRMCosmosDbSqlContainer_update (1284.63s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/cosmos/tests        1284.945s

[aqche]

update, able to reproduce the failing tests after merging latest master into my branch. will look into the cause.

[aqche]

turns out the reason the tests were failing was because the inputs were incorrect. it passed before b/c until recently database and account used the same naming format.

[katbyte]

Reran the tests and they passed, thanks @aqche

[ghost]

This has been released in version 1.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.42.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!