Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: 'azurerm_eventhub_consumer_group' #5518

Merged

Conversation

jackbatzner
Copy link
Contributor

Add new data source 'azurerm_eventhub_consumer_group'

=== RUN TestAccDataSourceAzureRMEventHubConsumerGroup_complete
=== PAUSE TestAccDataSourceAzureRMEventHubConsumerGroup_complete
=== CONT TestAccDataSourceAzureRMEventHubConsumerGroup_complete
--- PASS: TestAccDataSourceAzureRMEventHubConsumerGroup_complete (202.86s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/eventhub/tests
203.125s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this pr @Brunhil! overall LGTM aside from a few minor comments ive left inline

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @Brunhil

Thanks for pushing those changes - apologies this has sat waiting for a re-review.

Taking a look through this LGTM - I'll kick off the tests now 👍

Thanks!

@tombuildsstuff tombuildsstuff force-pushed the eventhub_consumer_group_datasource branch from f004f7f to 5aaf923 Compare February 11, 2020 14:45
@tombuildsstuff
Copy link
Member

@Brunhil hope you don't mind but I've pushed the rebase for this

@tombuildsstuff tombuildsstuff dismissed katbyte’s stale review February 11, 2020 14:47

dismissing since changes have been pushed

@tombuildsstuff
Copy link
Member

Test still passes:

Screenshot 2020-02-11 at 15 58 28

@tombuildsstuff tombuildsstuff merged commit 977fb0c into hashicorp:master Feb 11, 2020
tombuildsstuff added a commit that referenced this pull request Feb 11, 2020
@ghost
Copy link

ghost commented Feb 12, 2020

This has been released in version 1.44.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.44.0"
}
# ... other configuration ...

@jackbatzner jackbatzner deleted the eventhub_consumer_group_datasource branch March 14, 2020 14:49
@ghost
Copy link

ghost commented Mar 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Mar 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants