Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated managed_disk resource for disk_size_gb updates #5579

Merged
merged 2 commits into from Feb 3, 2020

Conversation

jackofallops
Copy link
Member

Works to address #2534

This resource should be used with azurerm_virtual_machine_data_disk_attachment for correct behaviour in #1668 also.

@jackofallops jackofallops added the service/disk-attachments Virtual Machine Disk Attachments label Jan 31, 2020
@jackofallops jackofallops added this to the v1.43.0 milestone Jan 31, 2020
@jackofallops jackofallops requested a review from a team January 31, 2020 17:15
@jackofallops jackofallops self-assigned this Jan 31, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment about locking to handle concurrent changes but this LGTM 👍

// check instanceView State
vmClient := meta.(*clients.Client).Compute.VMClient

instanceView, err := vmClient.InstanceView(ctx, virtualMachine.ResourceGroup, virtualMachine.Name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to lock on the Virtual Machine resource group/name here before doing these manipulations

@jackofallops jackofallops merged commit 3a159e1 into master Feb 3, 2020
@tombuildsstuff tombuildsstuff deleted the b/update-managed-disks-attachment branch February 3, 2020 09:53
@ghost
Copy link

ghost commented Feb 4, 2020

This has been released in version 1.43.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.43.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants