Allow setting target subnet and static IP on failover

[martenbohlin]

This pull request adds some configurability of the network interface when a failover is done.

The previous implementation finished once the initial setup was done and was not waiting for the replication to finish. But to configure the NIC we need to wait for the replication to finish before we can do that, in this pull request it will always wait for the replication even if no changes has to be done and I am not sure if that is desirable or not. Thoughts?

[martenbohlin]

Hi, is there something I can do to increase the chance of this pull request to be accepted? If it is the dependency update that is the concern I can take a look and see if it is possible to implement this without the upgrade.

Thanks for maintaining a great product! /Mårten

[jackofallops]

Hi @martenbohlin
I tried to push the notes below to be able to merge this for today's release, not realising that the fork is in an Org not your user so I don't have rights. If you can address @katbyte 's last remaining comment and correct the typo I've called out, I think we should be good to merge after running the tests.

Thanks.

[martenbohlin]

@jackofallops I have fixed the typo you pointed out. I think I have fixed all of @katbyte 's comments, but let me know if you have spotted something I have missed. Thanks

Changes addressed

[jackofallops]

Tests passing, failures are transient or intermittent unrelated items:

[ghost]

This has been released in version 2.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.23.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!