New Resource & Data Source: azurerm_database_migration_project #5993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
💤 terraform-provider-azurerm-data-migration [database_migration_project] ⚡ make testacc TEST="./azurerm/internal/services/databasemigration/tests" TESTARGS="-parallel=1 -run='TestAccAzureRMDatabaseMigrationProject_'"
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
TF_ACC=1 go test ./azurerm/internal/services/databasemigration/tests -v -parallel=1 -run='TestAccAzureRMDatabaseMigrationProject_' -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccAzureRMDatabaseMigrationProject_basic
=== PAUSE TestAccAzureRMDatabaseMigrationProject_basic
=== RUN TestAccAzureRMDatabaseMigrationProject_complete
--- PASS: TestAccAzureRMDatabaseMigrationProject_complete (1353.02s)
=== RUN TestAccAzureRMDatabaseMigrationProject_requiresImport
--- PASS: TestAccAzureRMDatabaseMigrationProject_requiresImport (1291.17s)
=== RUN TestAccAzureRMDatabaseMigrationProject_update
--- PASS: TestAccAzureRMDatabaseMigrationProject_update (1402.37s)
=== CONT TestAccAzureRMDatabaseMigrationProject_basic
--- PASS: TestAccAzureRMDatabaseMigrationProject_basic (1183.26s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/databasemigration/tests 5229.835s |
katbyte
requested changes
Mar 5, 2020
azurerm/internal/services/databasemigration/resource_arm_database_migration_project.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/databasemigration/resource_arm_database_migration_project.go
Outdated
Show resolved
Hide resolved
...rm/internal/services/databasemigration/tests/resource_arm_database_migration_project_test.go
Show resolved
Hide resolved
...rm/internal/services/databasemigration/tests/resource_arm_database_migration_project_test.go
Outdated
Show resolved
Hide resolved
...rm/internal/services/databasemigration/tests/resource_arm_database_migration_project_test.go
Outdated
Show resolved
Hide resolved
...rm/internal/services/databasemigration/tests/resource_arm_database_migration_project_test.go
Outdated
Show resolved
Hide resolved
Review [link](hashicorp#5993 (review)).
|
Hi @katbyte , really appreaciate your quick response. I have fixed the issue you pointed and also the ones in CI. 💤 terraform-provider-azurerm-data-migration [database_migration_project] ⚡ make testacc TEST="./azurerm/internal/services/databasemigration/tests" TESTARGS="-parallel=1 -run='TestAccAzureRMDatabaseMigrationProject_'"
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
TF_ACC=1 go test ./azurerm/internal/services/databasemigration/tests -v -parallel=1 -run='TestAccAzureRMDatabaseMigrationProject_' -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccAzureRMDatabaseMigrationProject_basic
=== PAUSE TestAccAzureRMDatabaseMigrationProject_basic
=== RUN TestAccAzureRMDatabaseMigrationProject_complete
--- PASS: TestAccAzureRMDatabaseMigrationProject_complete (1175.76s)
=== RUN TestAccAzureRMDatabaseMigrationProject_requiresImport
--- PASS: TestAccAzureRMDatabaseMigrationProject_requiresImport (1339.03s)
=== RUN TestAccAzureRMDatabaseMigrationProject_update
--- PASS: TestAccAzureRMDatabaseMigrationProject_update (1435.03s)
=== CONT TestAccAzureRMDatabaseMigrationProject_basic
--- PASS: TestAccAzureRMDatabaseMigrationProject_basic (2227.40s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/databasemigration/tests 6177.248s |
katbyte
requested changes
Mar 5, 2020
Comment on lines
146
to
148
| name := id.Name | ||
| resourceGroup := id.ResourceGroup | ||
| serviceName := id.Service |
There was a problem hiding this comment.
I don't think we need to assign these to locals?
Comment on lines
188
to
190
| name := id.Name | ||
| resourceGroup := id.ResourceGroup | ||
| serviceName := id.Service |
There was a problem hiding this comment.
I don't think we need to assign these to locals?
Comment on lines
124
to
126
| name := id.Name | ||
| resourceGroup := id.ResourceGroup | ||
| serviceName := id.Service |
There was a problem hiding this comment.
I don't think we need to assign these to locals?
Comment on lines
155
to
157
| name := id.Name | ||
| resourceGroup := id.ResourceGroup | ||
| serviceName := id.Service |
There was a problem hiding this comment.
I don't think we need to assign these to locals?
katbyte
approved these changes
Mar 5, 2020
katbyte
added a commit
that referenced
this pull request
Mar 5, 2020
|
This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.1.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement azurerm_database_migration_project.
See #5257 for more details.