Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_spatial_anchors_account #6011

Merged
merged 5 commits into from Mar 6, 2020

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Mar 6, 2020

--- PASS: TestAccAzureRMSpatialAnchorsAccount_tags (95.55s)
--- PASS: TestAccAzureRMSpatialAnchorsAccount_basic (141.28s)

@mbfrahry mbfrahry requested a review from a team March 6, 2020 00:34
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a couple comments LGTM @mbfrahry 👍

`, data.RandomInteger, data.Locations.Primary, data.RandomInteger)
}

func testAccAzureRMSpatialAnchorsAccount_tags(data acceptance.TestData) string {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just use complete for consistency/if new optional properties are added?

}

resource "azurerm_resource_group" "test" {
name = "acctestRG-%d"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we make the rg name reflect the service

Suggested change
name = "acctestRG-%d"
name = "acctestRG-mr-%d"

resource_group_name = azurerm_resource_group.test.name

tags = {
environment = "production"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should make sure casing is preserved

Suggested change
environment = "production"
Environment = "Production"

}

resource "azurerm_spatial_anchors_account" "test" {
name = "acctestdf%d"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and make sure upper case is preserved here too

@katbyte katbyte added this to the v2.1.0 milestone Mar 6, 2020
@mbfrahry mbfrahry merged commit 8340982 into master Mar 6, 2020
@mbfrahry mbfrahry deleted the f-spatial-anchor-account branch March 6, 2020 21:10
mbfrahry added a commit that referenced this pull request Mar 6, 2020
@ghost
Copy link

ghost commented Mar 11, 2020

This has been released in version 2.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.1.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants