Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make azurerm_linux_virtual_machine's custom_data field sensitive #6225

Merged
merged 1 commit into from Mar 25, 2020

Conversation

kazimierzbudzyk
Copy link
Contributor

@kazimierzbudzyk kazimierzbudzyk commented Mar 23, 2020

Addresses: #6185

Main motivation is to match ARM1.X's ability to not leak sensitive custom_data to plan output. Additional advantage is avoiding polluting plan with outputs that are not human-readable.

@ghost ghost added the size/XS label Mar 23, 2020
@katbyte katbyte added this to the v2.3.0 milestone Mar 24, 2020
@katbyte katbyte added the bug label Mar 24, 2020
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @kazimierzbudzyk

@ghost
Copy link

ghost commented Mar 27, 2020

This has been released in version 2.3.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.3.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contents of custom data visible in plan as base64 encoded string
3 participants